Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 10836222: Remove possibly outdated heapcheck suppression. (Closed)

Created:
8 years, 4 months ago by vandebo (ex-Chrome)
Modified:
8 years, 4 months ago
Reviewers:
kmadhusu
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Remove possibly outdated heapcheck suppression. BUG=141322 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/media_gallery/media_galleries_preferences_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vandebo (ex-Chrome)
Actually, it looks like this leak may have been fixed by r150764. Remove the speculative ...
8 years, 4 months ago (2012-08-13 23:28:10 UTC) #1
kmadhusu
lgtm
8 years, 4 months ago (2012-08-13 23:33:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10836222/1
8 years, 4 months ago (2012-08-13 23:34:06 UTC) #3
commit-bot: I haz the power
Try job failure for 10836222-1 (retry) (retry) on linux_rel for step "content_unittests". It's a second ...
8 years, 4 months ago (2012-08-14 00:58:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10836222/1
8 years, 4 months ago (2012-08-14 01:02:36 UTC) #5
commit-bot: I haz the power
Try job failure for 10836222-1 (previous was lost) (retry) (retry) on linux_chromeos for steps "browser_tests, ...
8 years, 4 months ago (2012-08-14 07:46:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10836222/1
8 years, 4 months ago (2012-08-14 17:02:18 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 19:27:12 UTC) #8
Change committed as 151539

Powered by Google App Engine
This is Rietveld 408576698