Extension docs: Update whats_new.html for M21.

Extension docs: Update whats_new.html for M21.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151856

[mkearney, 2012-08-13 23:51:50]

Thanks, Aaron, for pulling these together.

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/static/whats_new.html (right):

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:36:
>content_security_policy</a>.
Should this be under a "Manifest changes" heading? Also, are we removing apps
information from extension release notes? I'd suggest specifically mentioning
apps in the release note-- 'allows you to define some pages within your apps and
extensions that are automatically...'

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:40: editors</a> on Chrome
OS.
There's already an entry for the IME API in Google Chrome 18 which should
probably be removed. Adding a second comment for this.

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:41: </ul>
In addition to the sandbox field, should we also include under "Manifest
changes" something on registering web intents as content type viewers?
Or maybe this belongs in 'Additions to existing features'?

Something like:
<li><a href="manifest.html#intents">Web intents</a>
      can be registered as content type viewers.</li>

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:49:
>ChromeSetting.set</a></code> method now has a
Little nit - ChromeSetting.set().

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:56:
>showConfirmDialog</code> parameter.
A general comment: we don't need <code> tag for methods within an href.

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:71: that the tab should be
placed at the end.
Should we also mention that the "index" parameter is now optional for
chrome.tabs.move?

http://chromiumcodereview.appspot.com/9699065/

[mkearney, 2012-08-13 23:55:09]

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/static/whats_new.html (right):

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:175: directly to the
system's input device.
This should be removed (input method editor API), as it's been added in Chrome
21.

[Aaron Boodman, 2012-08-14 00:20:38]

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/static/whats_new.html (right):

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:36:
>content_security_policy</a>.
On 2012/08/13 23:51:50, mkearney wrote:
> Should this be under a "Manifest changes" heading?

I decided that separating "manifest" changes from "api" changes was not useful.
They are all just features.

> Also, are we removing apps
> information from extension release notes? I'd suggest specifically mentioning
> apps in the release note-- 'allows you to define some pages within your apps
and
> extensions that are automatically...'

Apps has their own release notes mechanism. This one is only published as part
of extensions.

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:40: editors</a> on Chrome
OS.
On 2012/08/13 23:51:50, mkearney wrote:
> There's already an entry for the IME API in Google Chrome 18 which should
> probably be removed. Adding a second comment for this.

That's weird! Removed.

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:41: </ul>
On 2012/08/13 23:51:50, mkearney wrote:
> In addition to the sandbox field, should we also include under "Manifest
> changes" something on registering web intents as content type viewers?
> Or maybe this belongs in 'Additions to existing features'?
> 
> Something like:
> <li><a href="manifest.html#intents">Web intents</a>
>       can be registered as content type viewers.</li>

Done.

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:49:
>ChromeSetting.set</a></code> method now has a
On 2012/08/13 23:51:50, mkearney wrote:
> Little nit - ChromeSetting.set().

Done.

https://chromiumcodereview.appspot.com/10836219/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/whats_new.html:56:
>showConfirmDialog</code> parameter.
On 2012/08/13 23:51:50, mkearney wrote:
> A general comment: we don't need <code> tag for methods within an href.

Done.

[mkearney, 2012-08-14 00:23:05]

lgtm

[commit-bot: I haz the power, 2012-08-14 00:29:20]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Mihai Parparita -not on Chrome, 2012-08-14 15:02:47]

LGTM

On Mon, Aug 13, 2012 at 5:29 PM, <commit-bot@chromium.org> wrote:

> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See
http://www.chromium.org/**getting-involved/become-a-**committer<http://www.ch...
> Note that this has nothing to do with OWNERS files.
>
>
https://chromiumcodereview.**appspot.com/10836219/<https://chromiumcodereview...
>

[commit-bot: I haz the power, 2012-08-14 18:03:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/10836219/2002

[commit-bot: I haz the power, 2012-08-14 18:03:03]

Presubmit check for 10836219-2002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to chrome/common/extensions/docs/static/whats_new.html not reflected
in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py --page-name=<apiName>

Presubmit checks took 1.3s to calculate.

[dmtabs12, 2012-08-16 06:59:18]

>> The sandbox manifest entry allows you to define some pages within your
extension that are automatically run in a low-privilege sandbox. This sandbox is
not bound by the content_security_policy.
The target of the link |content_security_policy| is not correct. It should be
https://developer.chrome.com/trunk/extensions/contentSecurityPolicy.html

[dmtabs12, 2012-08-16 07:14:51]

In addition, 
>> The a href="browserAction.html#method-setIcon" >browserAction.setIcon()
'<' missing.
>> The privacy.website namespace now has a protectedContentEnabled property.
should be privacy.websites