Rename template parameter in callback from RunType to BindRunType.

Rename template parameter in callback from RunType to BindRunType.

The original code is correct. The fix is a work around for mips gcc 4.3.2.

The constructor of Callback is a template. In the context of the constructor, there are two type named RunType. One is its second template parameter, the other is a typedef inside Callback. The correct compiler will pick the "local" one, i.e. the template parameter. However, gcc 4.3.2 on mips incorrectly uses the typedef. The solution is to rename the template parameter.

After discussing with ajwong, we decide to push the work around up stream as it is cleaner not to shadow names anyways.

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151383

[xiaomings, 2012-08-13 18:55:50]

Please review the changes, thanks :)

[xiaomings, 2012-08-13 19:36:56]

Please review the change, thanks :)

[awong, 2012-08-13 19:38:49]

https://chromiumcodereview.appspot.com/10836215/diff/3002/base/callback.h
File base/callback.h (right):

https://chromiumcodereview.appspot.com/10836215/diff/3002/base/callback.h#new...
base/callback.h:126: //   base::Callback<void(int)> cb = base::Bind(&MyFunc,
23);
Oops. Please fix the comment in the .pump file.  It should be

base::Callback<void(const std::string&)>

[awong, 2012-08-13 19:39:42]

In the CL description, and you add a sentence at the end that says something
like

  "It is cleaner not to shadow names anyways."

[xiaomings, 2012-08-13 21:09:12]

Fix the comment according to your comment.

[xiaomings, 2012-08-13 21:09:43]

Fixed comment according to your comment.

[awong, 2012-08-13 21:19:49]

LGTM

Darin: can you do OWNERS since Will is out?

[darin (slow to review), 2012-08-13 21:37:23]

LGTM

[commit-bot: I haz the power, 2012-08-13 21:38:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiaomings@google.com/10836215/1002

[commit-bot: I haz the power, 2012-08-13 23:11:51]

Change committed as 151383