Removed static factories for data, ftp, file, and about jobs.

Removed static factories for data, ftp, file, and about jobs.

BUG=142945

[shalev, 2012-08-23 19:53:54]

Hi Will and Matt,

This CL removes the built-in static factories (in favor of protocol handlers)
for everything except HTTP. Please take a look.

Thanks,

Shalev

[erikwright (departed), 2012-08-23 21:34:13]

LGTM. I think it might be appropriate to add a TODO in url_request_unittest
suggesting that it should be sharded into ProtocolHandler-specific unittests.

Really, all those tests that are setting up
FtpProtocolHandler/FileProtocolHandler are substantially testing those protocol
handlers, not URLRequest.

[mmenke, 2012-08-24 14:23:43]

There were a bunch of failing tests, some just because of log parsing issues
probably resulting from earlier failed tests, but suspect a number of them are
real failures.

http://codereview.chromium.org/10836206/diff/16003/net/url_request/url_reques...
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/10836206/diff/16003/net/url_request/url_reques...
net/url_request/url_request_http_job.cc:1029:
request_->context()->job_factory()->IsHandledURL(location))) {
nit:  Suggest

!URLRequest::IsHandledURL(location) &&
!request_->context()->job_factory()->IsHandledURL(location)

To make it more readable.

http://codereview.chromium.org/10836206/diff/16003/net/url_request/url_reques...
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/10836206/diff/16003/net/url_request/url_reques...
net/url_request/url_request_unittest.cc:2827: URLRequest req(GURL("file:///"),
&d, &default_context_);
This test should also have a file job factory.  You may want to just set it up
in the test fixture, rather than in individual tests, since it's not clear if
there are any other cases like this.

FileDirCancelTest should probably also have it.  ResolveShortcutTest probably
should as well.

[Zulkarnainmegat42, 2017-07-21 06:59:53]

zulkarnainmegat42@gmail.com changed reviewers:
+ Zulkarnainmegat42@gmail.com

[Zulkarnainmegat42, 2017-07-21 06:59:54]

lgtm

Fuck u

https://codereview.chromium.org/10836206/diff/16003/net/url_request/url_reque...
File net/url_request/url_request_http_job.cc (right):

https://codereview.chromium.org/10836206/diff/16003/net/url_request/url_reque...
net/url_request/url_request_http_job.cc:1029:
request_->context()->job_factory()->IsHandledURL(location))) {
On 2012/08/24 14:23:45, mmenke wrote:
> <font><font>Nit: Cadangkan! URLRequest :: IsHandledURL (location) &&! Request
_-> context () -> job_factory () -> IsHandledURL (location) Untuk menjadikannya
lebih mudah dibaca.
> </font></font>