Issue 10836205: Parse labels under File resource.

Issue 10836205: Parse labels under File resource. (Closed)

Created:
8 years, 4 months ago by kochi

Modified:
8 years, 4 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, satorux1, kinaba

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Parse labels under File resource. The labels include starred, trashed, hidden, restricted, viewed. BUG=chromium:127728 TEST=unit_tests --gtest_filter="DriveAPI*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151427

Patch Set 1 : . #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Fix for comments. #

Patch Set 4 : rebase. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -3 lines)			Patch
M	chrome/browser/chromeos/gdata/drive_api_parser.h	View	1 2 3	3 chunks	+47 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_api_parser.cc	View	1 2 3	3 chunks	+50 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc	View	1 2	2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/test/data/chromeos/drive/filelist.json	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hashimoto

http://codereview.chromium.org/10836205/diff/6001/chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc File chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc (right): http://codereview.chromium.org/10836205/diff/6001/chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc#newcode177 chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc:177: EXPECT_TRUE(file1.labels().is_viewed()); Could you add tests to ensure that other ...

8 years, 4 months ago (2012-08-14 02:23:10 UTC) #2

kochi

Thanks for the review! https://chromiumcodereview.appspot.com/10836205/diff/6001/chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc File chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc (right): https://chromiumcodereview.appspot.com/10836205/diff/6001/chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc#newcode177 chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc:177: EXPECT_TRUE(file1.labels().is_viewed()); On 2012/08/14 02:23:10, hashimoto ...

8 years, 4 months ago (2012-08-14 02:32:11 UTC) #3

commit-bot: I haz the power

8 years, 4 months ago (2012-08-14 04:49:47 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10836205/9001

Expand Messages | Collapse Messages