Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: content/renderer/pepper/pepper_file_chooser_host_unittest.cc

Issue 10836204: Fix the file chooser host unittest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/mock_renderer_ppapi_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/pepper_file_chooser_host_unittest.cc
diff --git a/content/renderer/pepper/pepper_file_chooser_host_unittest.cc b/content/renderer/pepper/pepper_file_chooser_host_unittest.cc
index d8440c09b578cd61144f95d0161200f685c44c00..2cf7ec0b9d210190774e455db44a84c4fd217d22 100644
--- a/content/renderer/pepper/pepper_file_chooser_host_unittest.cc
+++ b/content/renderer/pepper/pepper_file_chooser_host_unittest.cc
@@ -9,7 +9,6 @@
#include "content/public/common/file_chooser_params.h"
#include "content/renderer/pepper/mock_renderer_ppapi_host.h"
#include "content/renderer/pepper/pepper_file_chooser_host.h"
-//#include "content/renderer/pepper/pepper_instance_state_accessor.h"
#include "content/renderer/render_view_impl.h"
#include "content/test/test_content_client.h"
#include "ppapi/c/pp_errors.h"
@@ -72,13 +71,15 @@ std::string FilePathToUTF8(const FilePath::StringType& path) {
} // namespace
-/* TODO(brettw) fix & re-enable this test.
TEST_F(PepperFileChooserHostTest, Show) {
PP_Resource pp_resource = 123;
MockRendererPpapiHost host(view_, pp_instance());
PepperFileChooserHost chooser(&host, pp_instance(), pp_resource);
+ // Say there's a user gesture.
+ host.set_has_user_gesture(true);
+
std::vector<std::string> accept;
accept.push_back("text/plain");
PpapiHostMsg_FileChooser_Show show_msg(false, false, std::string(), accept);
@@ -134,7 +135,6 @@ TEST_F(PepperFileChooserHostTest, Show) {
EXPECT_EQ(FilePathToUTF8(selected_info.display_name),
chooser_results[0].name);
}
-*/
TEST_F(PepperFileChooserHostTest, NoUserGesture) {
PP_Resource pp_resource = 123;
« no previous file with comments | « content/renderer/pepper/mock_renderer_ppapi_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698