Issue 10836199: Clean up media gallery preferences.

Issue 10836199: Clean up media gallery preferences. (Closed)

Created:
8 years, 4 months ago by vandebo (ex-Chrome)

Modified:
8 years, 3 months ago

Reviewers:
Lei Zhang, Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean up media gallery preferences. Handle some todo's minor performance issues and some corner cases. BUG=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151390

Patch Set 2 : Address comments #

Patch Set 4 : Fix unit tets x2 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -52 lines)			Patch
M	chrome/browser/media_gallery/media_galleries_dialog_controller.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/media_gallery/media_galleries_preferences.h	View	1	4 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/media_gallery/media_galleries_preferences.cc	View		8 chunks	+61 lines, -48 lines	1 comment	Download
M	chrome/browser/media_gallery/media_galleries_preferences_unittest.cc	View	1 2 3	6 chunks	+95 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/10836199/diff/1/chrome/browser/media_gallery/media_galleries_preferences.h File chrome/browser/media_gallery/media_galleries_preferences.h (right): http://codereview.chromium.org/10836199/diff/1/chrome/browser/media_gallery/media_galleries_preferences.h#newcode106 chrome/browser/media_gallery/media_galleries_preferences.h:106: MediaGalleryPrefIdSet GalleriesForExtension( you should update the controller to use ...

8 years, 4 months ago (2012-08-11 00:07:14 UTC) #2

vandebo (ex-Chrome)

8 years, 4 months ago (2012-08-11 00:45:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10836199/7002

8 years, 4 months ago (2012-08-13 22:17:04 UTC) #5

Lei Zhang

8 years, 3 months ago (2012-09-15 01:17:17 UTC) #7

https://chromiumcodereview.appspot.com/10836199/diff/7002/chrome/browser/medi...
File chrome/browser/media_gallery/media_galleries_preferences.cc (right):

https://chromiumcodereview.appspot.com/10836199/diff/7002/chrome/browser/medi...
chrome/browser/media_gallery/media_galleries_preferences.cc:184:
device_map_[gallery_info.device_id].insert(gallery_info.pref_id);
I think you are missing brackets after the if statement.....

Expand Messages | Collapse Messages