Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 10836190: Fix sign/unsigned issue breaking SDK build bots (Closed)

Created:
8 years, 4 months ago by noelallen1
Modified:
8 years, 4 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Visibility:
Public.

Description

Fix sign/unsigned issue breaking SDK build bots TBR=sergeyu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151152

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_network_list_private.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10836190/1
8 years, 4 months ago (2012-08-10 17:39:08 UTC) #1
commit-bot: I haz the power
Try job failure for 10836190-1 (retry) on linux_rel for step "update". It's a second try, ...
8 years, 4 months ago (2012-08-10 18:47:17 UTC) #2
Sergey Ulanov
do you know why it wasn't a problem on chromium? http://codereview.chromium.org/10836190/diff/1/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_network_list_private.cc File ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_network_list_private.cc (right): http://codereview.chromium.org/10836190/diff/1/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_network_list_private.cc#newcode142 ...
8 years, 4 months ago (2012-08-10 19:35:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10836190/1
8 years, 4 months ago (2012-08-10 21:12:24 UTC) #4
noelallen1
8 years, 4 months ago (2012-08-10 21:14:39 UTC) #5
noelallen1
Native Client uses stricter warnings.
8 years, 4 months ago (2012-08-10 21:15:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10836190/5002
8 years, 4 months ago (2012-08-10 21:19:44 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 23:41:46 UTC) #8
Change committed as 151152

Powered by Google App Engine
This is Rietveld 408576698