Flush monomorphic ICs on context disposal instead of context exit.

Flush monomorphic ICs on context disposal instead of context exit.

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=12342

[ulan, 2012-08-10 14:29:20]

PTAL

[Michael Starzinger, 2012-08-10 15:49:10]

LGTM (with a few nits and one real comment in test-heap.cc).

https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-api.c...
test/cctest/test-api.cc:1: 
Don't remove the copyright line, looks like a typo.

https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-api.c...
test/cctest/test-api.cc:14642: v8::V8::ContextDisposedNotification();
Can we move that out of the loop to where the context is actually disposed? Also
if the line is right after the disposal, the comment is no longer needed I
think.

https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (left):

https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-heap....
test/cctest/test-heap.cc:2101: v8::V8::ContextDisposedNotification();
Yeah, that was an oversight when I added the test-case originally.

https://chromiumcodereview.appspot.com/10836189/diff/1/test/mjsunit/debug-scr...
File test/mjsunit/debug-script.js (right):

https://chromiumcodereview.appspot.com/10836189/diff/1/test/mjsunit/debug-scr...
test/mjsunit/debug-script.js:29: // Flags: --send-idle-notification
Do multiple "// Flags" lines work? Awesome! Add an empty newline after the
second "// Flags" line.

https://chromiumcodereview.appspot.com/10836189/diff/1/test/mjsunit/debug-scr...
test/mjsunit/debug-script.js:31: 
Drop this empty newline.

[Jakob Kummerow, 2012-08-16 13:17:56]

Drive-by comment.

The CL itself looks good to me, but you guys are the experts on this stuff.

https://chromiumcodereview.appspot.com/10836189/diff/1/test/mjsunit/debug-scr...
File test/mjsunit/debug-script.js (right):

https://chromiumcodereview.appspot.com/10836189/diff/1/test/mjsunit/debug-scr...
test/mjsunit/debug-script.js:29: // Flags: --send-idle-notification
On 2012/08/10 15:49:10, Michael Starzinger wrote:
> Do multiple "// Flags" lines work? Awesome!

It's a recent improvement: https://chromiumcodereview.appspot.com/10855099/ ;-)

[ulan, 2012-08-20 10:49:57]

Thanks, comments are addressed, landing.

https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-api.c...
test/cctest/test-api.cc:1: 
On 2012/08/10 15:49:10, Michael Starzinger wrote:
> Don't remove the copyright line, looks like a typo.

Done.

https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-api.c...
test/cctest/test-api.cc:14642: v8::V8::ContextDisposedNotification();
On 2012/08/10 15:49:10, Michael Starzinger wrote:
> Can we move that out of the loop to where the context is actually disposed?
Also
> if the line is right after the disposal, the comment is no longer needed I
> think.

Done.

https://chromiumcodereview.appspot.com/10836189/diff/1/test/mjsunit/debug-scr...
File test/mjsunit/debug-script.js (right):

https://chromiumcodereview.appspot.com/10836189/diff/1/test/mjsunit/debug-scr...
test/mjsunit/debug-script.js:31: 
On 2012/08/10 15:49:10, Michael Starzinger wrote:
> Drop this empty newline.

Done.