[chromeos] pyauto tests should auto login by default on chromeos

[chromeos] pyauto tests should auto login by default on chromeos

Tests should auto-login on chromeos by default, since most use cases
begin there. Provide a way to override it.

This helps with non-login pyauto functional tests on chromeos such that if (for
whatever reason) the device gets logged out in the middle of running
pyauto_functional.py, individual tests can still manage to carry on.

BUG=None
TEST=None

R=craigdh@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151311

[Nirnimesh, 2012-08-10 00:49:24]

The only interesting change is in pyauto.py
The changes in functional/ & chromoes_util.py are to accommodate it.
The change in policy_base.py is make it not override Login() or else it gets
called from pyauto.py during autologin.

[Nirnimesh, 2012-08-10 00:53:21]

> The change in policy_base.py is make it not override Login() or else it gets
> called from pyauto.py during autologin.

s/policy_base.py/chromeos_device_policy.py/

[craigdh, 2012-08-10 16:48:31]

LGTM.

[commit-bot: I haz the power, 2012-08-10 18:34:54]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[dennis_jeffrey, 2012-08-13 16:37:35]

LGTM with an optional nit

https://chromiumcodereview.appspot.com/10836187/diff/1/chrome/test/pyautolib/...
File chrome/test/pyautolib/chromeos/chromeos_utils.py (right):

https://chromiumcodereview.appspot.com/10836187/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/chromeos/chromeos_utils.py:31: # Should auto-login.
Nothing to do here.
should we add a TODO to remove this function (and this file)?