Fixing crash Crash Report - Stack Signature: content::RenderWidgetHostImpl::ForwardKeybo

Fixing crash Crash Report - Stack Signature: content::RenderWidgetHostImpl::ForwardKeybo


BUG=134465
TEST=by hand


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151121

[Mr4D (OOO till 08-26), 2012-08-10 00:22:53]

Ben - this is a long standing error which turned out to be - more or less
related to what derat was doing in our bug fixit (suppressing some key commands
in full screen mode).

(It is a branch stopper)

Please have a look!

[Ben Goodger (Google), 2012-08-10 15:00:12]

http://codereview.chromium.org/10836186/diff/1/chrome/browser/ui/browser_comm...
File chrome/browser/ui/browser_command_controller.cc (right):

http://codereview.chromium.org/10836186/diff/1/chrome/browser/ui/browser_comm...
chrome/browser/ui/browser_command_controller.cc:290: // Destroying a tab /
browser window while it has opened a full screen
Hrm. This works on Windows today (STR: open a new tab, press F11, press Ctrl+W).
No crash. So I don't know that we should remove this functionality... seems like
we're wallpapering over the real issue. Can you say more about why it's
crashing?

[Ben Goodger (Google), 2012-08-10 18:25:37]

make this OS_CHROMEOS only

then lgtm for landing on the trunk, merging to branch then immediate reversion
on trunk.

the correct fix is to make ash implement fullscreen like windows, moving the
browser window to the fullscreen container rahter than disembodying the
webcontents.

[Mr4D (OOO till 08-26), 2012-08-10 19:21:00]

Changed and submitting as discussed.

[commit-bot: I haz the power, 2012-08-10 19:21:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10836186/6001

[commit-bot: I haz the power, 2012-08-10 20:55:27]

Change committed as 151121