Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10836185: Implement GL_EXT_debug_marker (Closed)

Created:
8 years, 4 months ago by greggman
Modified:
8 years, 4 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Implement GL_EXT_debug_marker BUG=141700 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151194

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+690 lines, -108 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 5 chunks +62 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +22 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 68 chunks +124 lines, -69 lines 2 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +13 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A gpu/command_buffer/common/debug_marker_manager.h View 1 1 chunk +62 lines, -0 lines 4 comments Download
A gpu/command_buffer/common/debug_marker_manager.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download
A gpu/command_buffer/common/debug_marker_manager_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +98 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +37 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +31 lines, -28 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 9 chunks +44 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +36 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 chunk +11 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer_service.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy_untrusted.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
greggman
Hey Al, PTAL Will connect to to WebGraphicsContext3D in another CL.
8 years, 4 months ago (2012-08-09 23:21:56 UTC) #1
apatrick_chromium
Just some nits. LGTM. https://chromiumcodereview.appspot.com/10836185/diff/2003/gpu/command_buffer/client/gles2_implementation.cc File gpu/command_buffer/client/gles2_implementation.cc (right): https://chromiumcodereview.appspot.com/10836185/diff/2003/gpu/command_buffer/client/gles2_implementation.cc#newcode417 gpu/command_buffer/client/gles2_implementation.cc:417: this_in_hex_ = std::string(temp); There's a ...
8 years, 4 months ago (2012-08-10 19:29:31 UTC) #2
greggman
Hi Antoine, can you approve the PPAPI file? ty https://chromiumcodereview.appspot.com/10836185/diff/2003/gpu/command_buffer/client/gles2_implementation.cc File gpu/command_buffer/client/gles2_implementation.cc (right): https://chromiumcodereview.appspot.com/10836185/diff/2003/gpu/command_buffer/client/gles2_implementation.cc#newcode417 gpu/command_buffer/client/gles2_implementation.cc:417: ...
8 years, 4 months ago (2012-08-11 00:17:30 UTC) #3
piman
LGTM. +bbudge in case he has an opinion on that file.
8 years, 4 months ago (2012-08-11 00:41:17 UTC) #4
bbudge
That is for the existing NaCl SRPC proxy. LGTM
8 years, 4 months ago (2012-08-11 00:48:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10836185/2003
8 years, 4 months ago (2012-08-11 06:17:13 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-12 02:25:02 UTC) #7 
Change committed as 151194

Powered by Google App Engine
This is Rietveld 408576698