Obfuscated Gaia ID fetcher

chrome/browser/extensions/api/push_messaging/push_messaging_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_PUSH_MESSAGING_API_H__
 #define CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_PUSH_MESSAGING_API_H__
 
 #include <string>
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"

[dcheng, 2012/08/20 19:10:01]

#include "base/memory/scoped_ptr.h"

[Pete Williamson, 2012/08/20 20:53:05]

Done.

 #include "chrome/browser/extensions/api/push_messaging/invalidation_handler_observer.h"
+#include "chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h"
+#include "chrome/browser/extensions/extension_function.h"
+#include "chrome/common/net/gaia/google_service_auth_error.h"
 
 class Profile;
 
 namespace extensions {
 
 // Observes a single InvalidationHandler and generates onMessage events.
 class PushMessagingEventRouter : public InvalidationHandlerObserver {
  public:
   explicit PushMessagingEventRouter(Profile* profile);
   virtual ~PushMessagingEventRouter();
 
   void Init();
 
  private:
   FRIEND_TEST_ALL_PREFIXES(PushMessagingApiTest, EventDispatch);
 
   // InvalidationHandlerObserver implementation.
   virtual void OnMessage(const std::string& extension_id,
                          int subchannel,
                          const std::string& payload) OVERRIDE;
 
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(PushMessagingEventRouter);
 };
 
+class PushMessagingGetChannelIdFunction
+  : public AsyncExtensionFunction, public ObfuscatedGaiaIdFetcher::Delegate{

[dcheng, 2012/08/20 19:10:01]

Indent two spaces. Missing space before {

[Pete Williamson, 2012/08/20 20:53:05]

Added spaces

+ public:
+  PushMessagingGetChannelIdFunction();
+
+ protected:
+  virtual ~PushMessagingGetChannelIdFunction();
+
+  // ExtensionFunction:
+  virtual bool RunImpl() OVERRIDE;
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.pushMessaging.getChannelId");
+
+ private:
+  void GetChannelIdOnIOThread();
+  void RespondOnUIThread(const std::string& gaiaId, const long status);
+  void StartGaiaIdFetch();
+  virtual void OnObfuscatedGaiaIdFetchSuccess(const std::string& gaia_id)

[dcheng, 2012/08/20 19:10:01]

I'd add a comment here:
// ObfuscatedGiaiaIdFetcher::Delegate implementation.

[Pete Williamson, 2012/08/20 20:53:05]

Done.

+      OVERRIDE;
+  virtual void OnObfuscatedGaiaIdFetchFailure(
+      const GoogleServiceAuthError& error) OVERRIDE;
+  scoped_ptr<ObfuscatedGaiaIdFetcher> fetcher_;
+
+  DISALLOW_COPY_AND_ASSIGN(PushMessagingGetChannelIdFunction);
+};
+
 }  // namespace extension
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_PUSH_MESSAGING_API_H__