Obfuscated Gaia ID fetcher

chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/push_messaging/push_messaging_api.h"
 
 #include "base/bind.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/event_names.h"
 #include "chrome/browser/extensions/event_router.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/signin/token_service.h"
+#include "chrome/browser/signin/token_service_factory.h"
 #include "chrome/common/extensions/api/experimental_push_messaging.h"
 #include "content/public/browser/browser_thread.h"
 #include "googleurl/src/gurl.h"
+#include "chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h"
+
+using content::BrowserThread;
 
 namespace extensions {
 
 namespace glue = extensions::api::experimental_push_messaging;
 
 PushMessagingEventRouter::PushMessagingEventRouter(Profile* profile)
     : profile_(profile) {
 }
 
 PushMessagingEventRouter::~PushMessagingEventRouter() {}
@@ skipping 11 matching lines @@
 
   scoped_ptr<base::ListValue> args(glue::OnMessage::Create(message));
   profile_->GetExtensionEventRouter()->DispatchEventToExtension(
       extension_id,
       event_names::kOnPushMessage,
       args.Pass(),
       profile_,
       GURL());
 }
 
+PushMessagingGetChannelIdFunction::PushMessagingGetChannelIdFunction() {}
+
+PushMessagingGetChannelIdFunction::~PushMessagingGetChannelIdFunction() {}
+
+bool PushMessagingGetChannelIdFunction::RunImpl() {
+  // Start the async fetch of the GAIA ID.
+  StartGaiaIdFetch();
+
+  // Will finish asynchronously.
+  return true;
+}
+
+void PushMessagingGetChannelIdFunction::RespondOnUIThread(

[Munjal (Google), 2012/08/20 20:01:25]

I still don't understand fully whether we need to do the thread task positng
explicitly here or not. Can you please explain why we need this?

[Pete Williamson, 2012/08/20 20:53:05]

We aren't doing any thread posting anymore.  Changed the name of this function
to "Respond" to avoid any potential confusion.

+    const std::string& gaia_id, const long status) {

[dcheng, 2012/08/20 19:10:01]

Just 'long' instead of 'const long'

[Pete Williamson, 2012/08/20 20:53:05]

Done.

+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  // Unpack the status and GaiaId parameters, and use it to build the
+  // channel ID here.
+  std::string channel_id(gaia_id);
+  if (!gaia_id.empty()) {
+    channel_id += ".";
+    channel_id += extension_id();
+  }
+
+  // TODO: (after initial checkin) It may be a good idea to further

[dcheng, 2012/08/20 19:10:01]

TODO(petewil)

[Pete Williamson, 2012/08/20 20:53:05]

Done.

+  // obfuscate the channel ID to prevent the user's obfuscated GAIA ID
+  // from being readily obtained.  Security review will tell us if we need to.
+
+  // Create a ChannelId results object and set the fields.
+  glue::ChannelIdResult result;
+  result.channel_id = channel_id;
+  result.status = status;
+  results_ = glue::GetChannelId::Results::Create(result);
+  SendResponse(true);
+
+  // Once we have handed off the response, we can allow the
+  // PushMessagingGetChannelIdFunction object to die.
+  Release();
+}
+
+// Member function to start the fetch operation.
+// This must be called on the UI thread.
+void PushMessagingGetChannelIdFunction::StartGaiaIdFetch() {
+  net::URLRequestContextGetter* context = profile()->GetRequestContext();
+  TokenService* token_service = TokenServiceFactory::GetForProfile(profile());
+  const std::string&  refresh_token =

[dcheng, 2012/08/20 19:10:01]

One space.

[Pete Williamson, 2012/08/20 20:53:05]

Done.

+      token_service->GetOAuth2LoginRefreshToken();
+
+  fetcher_.reset(new ObfuscatedGaiaIdFetcher(context, this, refresh_token));
+  // Keep the PushMessagingGetChannelIdFunction object alive until we get
+  // a response.
+  AddRef();

[dcheng, 2012/08/20 19:10:01]

My preference would be to move this into RunImpl, above the return statement.
The rationale for this is RunImpl is a common interface for ExtensionFunctions
to implement so it's easier to find it there if someone is just searching
through the code.

[Pete Williamson, 2012/08/20 20:53:05]

Done. (Actually, I moved the whole function into RunImpl - there wasn't much
left when I moved the AddRef and Start

+  fetcher_->Start();
+}
+
+void PushMessagingGetChannelIdFunction::OnObfuscatedGaiaIdFetchSuccess(
+    const std::string& gaia_id) {
+  RespondOnUIThread(gaia_id, 0);
+}
+
+void PushMessagingGetChannelIdFunction::OnObfuscatedGaiaIdFetchFailure(
+      const GoogleServiceAuthError& error) {
+  RespondOnUIThread(std::string(), error.state());
+}
+
 }  // namespace extensions