Obfuscated Gaia ID fetcher

chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h"
+
+#include <string>
+#include <vector>
+
+#include "base/json/json_reader.h"
+#include "base/values.h"
+#include "chrome/common/net/gaia/google_service_auth_error.h"
+#include "net/url_request/url_fetcher.h"
+#include "net/url_request/url_request_status.h"
+
+using net::URLFetcher;
+using net::URLRequestContextGetter;
+using net::URLRequestStatus;
+
+namespace {
+
+// URL of the service to get obfuscated GAIA ID (here misnamed channel ID).
+static const char kCWSChannelServiceURL[] =
+    "https://www.googleapis.com/chromewebstore/v1.1/channels/id";
+
+static GoogleServiceAuthError CreateAuthError(URLRequestStatus status) {
+  if (status.status() == URLRequestStatus::CANCELED) {
+    return GoogleServiceAuthError(GoogleServiceAuthError::REQUEST_CANCELED);
+  } else {
+    // TODO(munjal): Improve error handling. Currently we return connection
+    // error for even application level errors. We need to either expand the
+    // GoogleServiceAuthError enum or create a new one to report better
+    // errors.
+    DLOG(WARNING) << "Server returned error: errno " << status.error();
+    return GoogleServiceAuthError::FromConnectionError(status.error());
+  }
+}
+

[dcheng, 2012/08/20 19:10:01]

Generally we don't use double newlines to separate methods/namespaces.

[Pete Williamson, 2012/08/20 20:53:05]

Done.

+
+// We use this static function to encapsulate the scopes needed at ctor time.

[Munjal (Google), 2012/08/20 20:01:25]

Nit: may be just say "Returns a vector of scopes needed to call the API to get
obfuscated gaia id."

[Pete Williamson, 2012/08/20 20:53:05]

Done.

+std::vector<std::string> GetScopes() {
+  std::vector<std::string> scopes;
+  scopes.push_back(
+    "https://www.googleapis.com/auth/chromewebstore.notification");

[Munjal (Google), 2012/08/20 20:01:25]

NIt: style issue: indent 4 spaces

[Pete Williamson, 2012/08/20 20:53:05]

Done.

+  return scopes;
+}
+
+}  // namespace
+
+
+namespace extensions {
+
+ObfuscatedGaiaIdFetcher::ObfuscatedGaiaIdFetcher(
+    URLRequestContextGetter* context,
+    Delegate* delegate,
+    const std::string& refresh_token)
+    : OAuth2ApiCallFlow(context, refresh_token, std::string(), GetScopes()),
+      delegate_(delegate) {
+}
+
+ObfuscatedGaiaIdFetcher::~ObfuscatedGaiaIdFetcher() { }
+
+void ObfuscatedGaiaIdFetcher::ReportSuccess(const std::string& obfuscated_id) {
+  if (delegate_ != NULL)
+    delegate_->OnObfuscatedGaiaIdFetchSuccess(obfuscated_id);
+}
+
+void ObfuscatedGaiaIdFetcher::ReportFailure(
+    const GoogleServiceAuthError& error) {
+  if (delegate_ != NULL)
+    delegate_->OnObfuscatedGaiaIdFetchFailure(error);
+}
+
+GURL ObfuscatedGaiaIdFetcher::CreateApiCallUrl() {
+  return GURL(kCWSChannelServiceURL);
+}
+
+std::string ObfuscatedGaiaIdFetcher::CreateApiCallBody() {
+  // Nothing to do here, we don't need a body for this request, the URL
+  // encodes all the proper arguments.
+  return std::string();
+}
+
+void ObfuscatedGaiaIdFetcher::ProcessApiCallSuccess(
+    const net::URLFetcher* source) {
+  // TODO(munjal): Change error code paths in this method to report an

[Munjal (Google), 2012/08/20 20:01:25]

Nit: I am ok with my name in the TODO. But just making sure you did this
intentionally vs a copy/paste artifact.

[Pete Williamson, 2012/08/20 20:53:05]

This was a copy/ paste artifact, but I think it is still valid, this should be
fixed at the same time as the code I pasted from.

+  // internal error.
+  std::string response_body;
+  CHECK(source->GetResponseAsString(&response_body));
+
+  std::string channel_id;
+  if (ParseResponse(response_body, &channel_id))
+    ReportSuccess(channel_id);
+  else
+    ReportFailure(GoogleServiceAuthError::FromConnectionError(101));
+}
+
+void ObfuscatedGaiaIdFetcher::ProcessApiCallFailure(
+    const net::URLFetcher* source) {
+  ReportFailure(CreateAuthError(source->GetStatus()));
+}
+
+void ObfuscatedGaiaIdFetcher::ProcessNewAccessToken(
+    const std::string& obfuscated_id)  {
+  // We generate a new access token every time instead of storing the access
+  // token since access token expire every hour and we expect to get
+  // obfuscated gaia id very infrequently.
+}
+
+void ObfuscatedGaiaIdFetcher::ProcessMintAccessTokenFailure(
+    const GoogleServiceAuthError& error)  {
+  // We failed to generate the token needed to call the API to get
+  // the obfuscated user ID, so report failure to the caller.
+  ReportFailure(error);
+}
+
+// static
+bool ObfuscatedGaiaIdFetcher::ParseResponse(
+    const std::string& data, std::string* result) {
+  scoped_ptr<base::Value> value(base::JSONReader::Read(data));
+
+  if (!value.get())
+    return false;
+
+  DictionaryValue* dict = NULL;
+  bool rv = value->GetAsDictionary(&dict);
+  if (!rv || NULL == dict)

[dcheng, 2012/08/20 19:10:01]

It is unnecessary to check that dict is NULL. So you can just do if
(!value->GetAsDictionary(&dict)) return false;

[Pete Williamson, 2012/08/20 20:53:05]

Done.

+    return false;
+
+  return dict->GetString("id", result);
+}
+
+}  // namespace extensions