Issue 10836176: Fixing drag out of maximize dialog button problem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836176: Fixing drag out of maximize dialog button problem (Closed)

Created:
8 years, 4 months ago by Mr4D (OOO till 08-26)

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixing drag out of maximize dialog button problem Clicking on a maximizer dialog button and dragging out of the dialog left the phantom window open BUG=141438 TEST=Visual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150854

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ash/wm/workspace/frame_maximize_button.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Mr4D (OOO till 08-26)

There was one more bug coming in yesterday after I (tried) to submit the other ...

8 years, 4 months ago (2012-08-09 14:23:49 UTC) #1

sky

LGTM - make sure when you get the tests straightened out that you add coverage ...

8 years, 4 months ago (2012-08-09 16:11:59 UTC) #2

Mr4D (OOO till 08-26)

Started already working on that in parallel and noted that case already :). (But thanks ...

8 years, 4 months ago (2012-08-09 16:17:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10836176/1

8 years, 4 months ago (2012-08-09 16:17:50 UTC) #4

Change committed as 150854