Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: content/renderer/browser_plugin/browser_plugin_browsertest.cc

Issue 10836169: Revert 150664 - Browser Plugin: Report Guest crash to Javascript (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/browser_plugin/browser_plugin_browsertest.cc
===================================================================
--- content/renderer/browser_plugin/browser_plugin_browsertest.cc (revision 150678)
+++ content/renderer/browser_plugin/browser_plugin_browsertest.cc (working copy)
@@ -238,22 +238,8 @@
BrowserPluginHostMsg_HandleInputEvent::ID));
browser_plugin_manager()->sink().ClearMessages();
- const char* kAddEventListener =
- "var msg;"
- "function crashListener() {"
- " msg = 'crashed';"
- "}"
- "document.getElementById('browserplugin')."
- " addEventListener('crash', crashListener);";
-
- ExecuteJavaScript(kAddEventListener);
-
// Pretend that the guest has crashed
browser_plugin->GuestCrashed();
-
- // Verify that our event listener has fired.
- EXPECT_EQ("crashed", ExecuteScriptAndReturnString("msg"));
-
// Send an event and verify that events are no longer deported.
browser_plugin->handleInputEvent(WebKit::WebMouseEvent(),
cursor_info);
@@ -263,6 +249,7 @@
// Navigate and verify that the guest_crashed_ flag has been reset.
browser_plugin->SetSrcAttribute("bar");
EXPECT_FALSE(browser_plugin->guest_crashed_);
+
}
TEST_F(BrowserPluginTest, RemovePlugin) {
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698