Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2051)

Unified Diff: chrome/browser/ui/panels/old_panel_browsertest.cc

Issue 10836159: Fix bug 141013: OldPanelBrowserTest.CheckDockedPanelProperties is flaky (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix per feedback Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/old_panel_browsertest.cc
diff --git a/chrome/browser/ui/panels/old_panel_browsertest.cc b/chrome/browser/ui/panels/old_panel_browsertest.cc
index f8161454aad81d876e8883b234c38cb63e0eefd9..1762814940744d51e2b7b15e911377c8d797b48c 100644
--- a/chrome/browser/ui/panels/old_panel_browsertest.cc
+++ b/chrome/browser/ui/panels/old_panel_browsertest.cc
@@ -24,7 +24,6 @@
#include "chrome/browser/ui/panels/native_panel.h"
#include "chrome/browser/ui/panels/panel.h"
#include "chrome/browser/ui/panels/panel_manager.h"
-#include "chrome/browser/ui/panels/test_panel_mouse_watcher.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/web_applications/web_app.h"
#include "chrome/common/chrome_notification_types.h"
@@ -257,13 +256,7 @@ class OldPanelBrowserTest : public OldBasePanelBrowserTest {
}
};
-// http://crbug.com/141013
-#if defined(OS_WIN)
-#define MAYBE_CheckDockedPanelProperties DISABLED_CheckDockedPanelProperties
-#else
-#define MAYBE_CheckDockedPanelProperties CheckDockedPanelProperties
-#endif
-IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, MAYBE_CheckDockedPanelProperties) {
+IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, CheckDockedPanelProperties) {
PanelManager* panel_manager = PanelManager::GetInstance();
DockedPanelStrip* docked_strip = panel_manager->docked_strip();
@@ -481,10 +474,6 @@ IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, AnimateBounds) {
}
IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, RestoredBounds) {
- // Disable mouse watcher. We don't care about mouse movements in this test.
- PanelManager* panel_manager = PanelManager::GetInstance();
- PanelMouseWatcher* mouse_watcher = new TestPanelMouseWatcher();
- panel_manager->SetMouseWatcherForTesting(mouse_watcher);
Panel* panel = CreatePanelWithBounds("PanelTest", gfx::Rect(0, 0, 100, 100));
EXPECT_EQ(Panel::EXPANDED, panel->expansion_state());
EXPECT_EQ(panel->GetBounds(), panel->GetRestoredBounds());
@@ -542,10 +531,6 @@ IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, RestoredBounds) {
}
IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, MinimizeRestore) {
- // We'll simulate mouse movements for test.
- PanelMouseWatcher* mouse_watcher = new TestPanelMouseWatcher();
- PanelManager::GetInstance()->SetMouseWatcherForTesting(mouse_watcher);
-
// Test with one panel.
CreatePanelWithBounds("PanelTest1", gfx::Rect(0, 0, 100, 100));
TestMinimizeRestore();
@@ -554,10 +539,6 @@ IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, MinimizeRestore) {
}
IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, MinimizeRestoreTwoPanels) {
- // We'll simulate mouse movements for test.
- PanelMouseWatcher* mouse_watcher = new TestPanelMouseWatcher();
- PanelManager::GetInstance()->SetMouseWatcherForTesting(mouse_watcher);
-
// Test with two panels.
CreatePanelWithBounds("PanelTest1", gfx::Rect(0, 0, 100, 100));
CreatePanelWithBounds("PanelTest2", gfx::Rect(0, 0, 110, 110));
@@ -567,10 +548,6 @@ IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, MinimizeRestoreTwoPanels) {
}
IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, MinimizeRestoreThreePanels) {
- // We'll simulate mouse movements for test.
- PanelMouseWatcher* mouse_watcher = new TestPanelMouseWatcher();
- PanelManager::GetInstance()->SetMouseWatcherForTesting(mouse_watcher);
-
// Test with three panels.
CreatePanelWithBounds("PanelTest1", gfx::Rect(0, 0, 100, 100));
CreatePanelWithBounds("PanelTest2", gfx::Rect(0, 0, 110, 110));
@@ -628,10 +605,6 @@ IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, MinimizeRestoreButtonClick) {
}
IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, RestoreAllWithTitlebarClick) {
- // We'll simulate mouse movements for test.
- PanelMouseWatcher* mouse_watcher = new TestPanelMouseWatcher();
- PanelManager::GetInstance()->SetMouseWatcherForTesting(mouse_watcher);
-
// Test with three panels.
Panel* panel1 = CreatePanel("PanelTest1");
Panel* panel2 = CreatePanel("PanelTest2");
@@ -968,10 +941,6 @@ IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, DrawAttentionBasic) {
}
IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, DrawAttentionWhileMinimized) {
- // We'll simulate mouse movements for test.
- PanelMouseWatcher* mouse_watcher = new TestPanelMouseWatcher();
- PanelManager::GetInstance()->SetMouseWatcherForTesting(mouse_watcher);
-
// Create 3 panels so we end up with an inactive panel that can
// be made to draw attention.
Panel* panel = CreatePanel("test panel1");
@@ -1021,10 +990,6 @@ IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, DrawAttentionWhileMinimized) {
// is stopped when there are other minimized panels.
IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest,
StopDrawingAttentionWhileMinimized) {
- // We'll simulate mouse movements for test.
- PanelMouseWatcher* mouse_watcher = new TestPanelMouseWatcher();
- PanelManager::GetInstance()->SetMouseWatcherForTesting(mouse_watcher);
-
Panel* panel1 = CreatePanel("panel1");
Panel* panel2 = CreatePanel("panel2");

Powered by Google App Engine
This is Rietveld 408576698