Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10836159: Fix bug 141013: OldPanelBrowserTest.CheckDockedPanelProperties is flaky (Closed)

Created:
8 years, 4 months ago by jianli
Modified:
8 years, 4 months ago
Reviewers:
jennb
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng
Visibility:
Public.

Description

Fix bug 141013: OldPanelBrowserTest.CheckDockedPanelProperties is flaky BUG=141013 TEST=Existing test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150668

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix per feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -104 lines) Patch
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/docked_panel_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/old_docked_panel_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/old_panel_and_desktop_notification_browsertest.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_browsertest.cc View 1 9 chunks +1 line, -36 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_drag_browsertest.cc View 1 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 9 chunks +0 lines, -34 lines 0 comments Download
M chrome/browser/ui/panels/panel_drag_browsertest.cc View 1 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jianli
8 years, 4 months ago (2012-08-08 22:00:27 UTC) #1
jennb
http://codereview.chromium.org/10836159/diff/1/chrome/browser/ui/panels/old_panel_browsertest.cc File chrome/browser/ui/panels/old_panel_browsertest.cc (right): http://codereview.chromium.org/10836159/diff/1/chrome/browser/ui/panels/old_panel_browsertest.cc#newcode264 chrome/browser/ui/panels/old_panel_browsertest.cc:264: // Don't let actual mouse movements affect this test ...
8 years, 4 months ago (2012-08-08 22:04:08 UTC) #2
jianli
http://codereview.chromium.org/10836159/diff/1/chrome/browser/ui/panels/old_panel_browsertest.cc File chrome/browser/ui/panels/old_panel_browsertest.cc (right): http://codereview.chromium.org/10836159/diff/1/chrome/browser/ui/panels/old_panel_browsertest.cc#newcode264 chrome/browser/ui/panels/old_panel_browsertest.cc:264: // Don't let actual mouse movements affect this test ...
8 years, 4 months ago (2012-08-08 22:28:55 UTC) #3
jennb
LGTM
8 years, 4 months ago (2012-08-08 22:40:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/10836159/4001
8 years, 4 months ago (2012-08-08 23:58:32 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 01:20:27 UTC) #6 
Change committed as 150668

Powered by Google App Engine
This is Rietveld 408576698