Fix DCHECK error when using multi window resizer on the 2nd display that is place on the left side.

Fix DCHECK error when using multi window resizer on the 2nd display that is place on the left side.

The cause of the error was work_area in screen coordinates was passed to CalculateAttachedSizes while bounds is in |window()->parent()|'s coordinates.

BUG=139231
TEST=Set the 2nd display on left, open two windows and use multi window resizer on debug build, and check crash does not occur.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150911

[oshima, 2012-08-09 00:59:35]

Can you fix bug number as well? It looks wrong.

http://codereview.chromium.org/10836157/diff/1/ash/wm/workspace/workspace_win...
File ash/wm/workspace/workspace_window_resizer.cc (right):

http://codereview.chromium.org/10836157/diff/1/ash/wm/workspace/workspace_win...
ash/wm/workspace/workspace_window_resizer.cc:289:
gfx::Screen::GetDisplayNearestWindow(window()).work_area()));
Can you use ScreenAsh::GetDisplayWorkAreaInParent() ?

[mazda, 2012-08-09 01:07:19]

Thank you for the review.
I fixed the issue number and addressed the comment.
Please take another look.

http://codereview.chromium.org/10836157/diff/1/ash/wm/workspace/workspace_win...
File ash/wm/workspace/workspace_window_resizer.cc (right):

http://codereview.chromium.org/10836157/diff/1/ash/wm/workspace/workspace_win...
ash/wm/workspace/workspace_window_resizer.cc:289:
gfx::Screen::GetDisplayNearestWindow(window()).work_area()));
On 2012/08/09 00:59:35, oshima wrote:
> Can you use ScreenAsh::GetDisplayWorkAreaInParent() ?

Done.

[oshima, 2012-08-09 01:36:48]

lgtm

[mazda, 2012-08-09 01:52:20]

Scott, could you do an OWNERS review for ash?

[sky, 2012-08-09 15:57:33]

LGTM

http://codereview.chromium.org/10836157/diff/4001/ash/wm/workspace/workspace_...
File ash/wm/workspace/workspace_window_resizer.cc (right):

http://codereview.chromium.org/10836157/diff/4001/ash/wm/workspace/workspace_...
ash/wm/workspace/workspace_window_resizer.cc:286: // |bounds| and |work_area|
are in |window()->parent()|'s coordinates.
Remove comment since coordinate system is documented in the header.

[mazda, 2012-08-09 16:08:50]

http://codereview.chromium.org/10836157/diff/4001/ash/wm/workspace/workspace_...
File ash/wm/workspace/workspace_window_resizer.cc (right):

http://codereview.chromium.org/10836157/diff/4001/ash/wm/workspace/workspace_...
ash/wm/workspace/workspace_window_resizer.cc:286: // |bounds| and |work_area|
are in |window()->parent()|'s coordinates.
On 2012/08/09 15:57:33, sky wrote:
> Remove comment since coordinate system is documented in the header.

Done.

[commit-bot: I haz the power, 2012-08-09 16:10:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10836157/10001

[commit-bot: I haz the power, 2012-08-09 19:00:46]

Try job failure for 10836157-10001 (retry) on win_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-09 20:55:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10836157/10001

[commit-bot: I haz the power, 2012-08-09 22:07:27]

Change committed as 150911