src/conversions-inl.h - Issue 10836151: Fix parseInt's octal parsing behavior (ECMA-262 Annex E 15.1.2.2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/conversions-inl.h

Issue 10836151: Fix parseInt's octal parsing behavior (ECMA-262 Annex E 15.1.2.2). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/conversions-inl.h

diff --git a/src/conversions-inl.h b/src/conversions-inl.h

index bf2232562e7946f2636d4ae8fcbcdda149a9551c..e272fe6c08d8dfa8f326a12ac0e84e7c81b4d1e1 100644

--- a/src/conversions-inl.h

+++ b/src/conversions-inl.h

@@ -268,6 +268,7 @@ double InternalStringToInt(UnicodeCache* unicode_cache,

if (radix == 0) {

// Radix detection.

+ radix = 10;

if (*current == '0') {

++current;

if (current == end) return SignedZero(negative);

@@ -276,11 +277,8 @@ double InternalStringToInt(UnicodeCache* unicode_cache,

++current;

if (current == end) return JunkStringValue();

} else {

- radix = 8;

leading_zero = true;

}

- } else {

- radix = 10;

}

} else if (radix == 16) {

if (*current == '0') {

« no previous file with comments | « no previous file | test/mjsunit/parse-int-float.js » ('j') | no next file with comments »