Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 10836150: Revert 150375 - Implement SHA-256 fingerprint support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_nss.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_nss.cc
===================================================================
--- net/socket/ssl_client_socket_nss.cc (revision 150506)
+++ net/socket/ssl_client_socket_nss.cc (working copy)
@@ -131,8 +131,8 @@
#elif defined(USE_NSS)
typedef SECStatus
(*CacheOCSPResponseFromSideChannelFunction)(
- CERTCertDBHandle* handle, CERTCertificate* cert, PRTime time,
- SECItem* encodedResponse, void* pwArg);
+ CERTCertDBHandle *handle, CERTCertificate *cert, PRTime time,
+ SECItem *encodedResponse, void *pwArg);
// On Linux, we dynamically link against the system version of libnss3.so. In
// order to continue working on systems without up-to-date versions of NSS we
@@ -2763,14 +2763,10 @@
ssl_info->connection_status =
core_->state().ssl_connection_status;
ssl_info->public_key_hashes = server_cert_verify_result_.public_key_hashes;
- // TODO(palmer) TODO(agl): Do side pins need to be in both SHA1 and SHA256
- // forms? If consumers of side pins only care about SHA1, it is OK to put
- // them only in the HASH_VALUE_SHA1 vector.
- HashValueVector& sha1_hashes =
- ssl_info->public_key_hashes[HASH_VALUE_SHA1];
- for (HashValueVector::const_iterator i = side_pinned_public_keys_.begin();
- i != side_pinned_public_keys_.end(); ++i) {
- sha1_hashes.push_back(*i);
+ for (std::vector<SHA1Fingerprint>::const_iterator
+ i = side_pinned_public_keys_.begin();
+ i != side_pinned_public_keys_.end(); i++) {
+ ssl_info->public_key_hashes.push_back(*i);
}
ssl_info->is_issued_by_known_root =
server_cert_verify_result_.is_issued_by_known_root;
« no previous file with comments | « net/socket/ssl_client_socket_nss.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698