Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 10836149: Use checked in android_tools Android NDK. (Closed)

Created:
8 years, 4 months ago by navabi1
Modified:
8 years, 4 months ago
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use checked in android_tools Android NDK. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150614

Patch Set 1 #

Patch Set 2 : Change this CL to not update to android sdk api 16. CL for that committed. #

Patch Set 3 : Did a "rebase" manually by stashing changes, syncing and replaying changes. #

Patch Set 4 : Patch the CL. #

Patch Set 5 : Update NDK used to revision with 64-bit linkers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M build/android/buildbot_functions.sh View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
M build/android/envsetup_functions.sh View 1 2 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
navabi
8 years, 4 months ago (2012-08-08 02:57:37 UTC) #1
Isaac (away)
this CL changes SDK version from 15 to 16?
8 years, 4 months ago (2012-08-08 05:09:13 UTC) #2
Isaac (away)
seems fine, let's rereview after a rebase on top of submitted CL
8 years, 4 months ago (2012-08-08 05:27:26 UTC) #3
Isaac (away)
lgtm but someone else must approve
8 years, 4 months ago (2012-08-08 05:27:59 UTC) #4
navabi
On 2012/08/08 05:09:13, Isaac wrote: > this CL changes SDK version from 15 to 16? ...
8 years, 4 months ago (2012-08-08 05:30:39 UTC) #5
Isaac (away)
yep, I wrote that before I saw patch 2. Looks good.
8 years, 4 months ago (2012-08-08 05:33:00 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-08-08 06:10:40 UTC) #7
klobag.chromium
lgtm
8 years, 4 months ago (2012-08-08 06:53:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@chromium.org/10836149/8001
8 years, 4 months ago (2012-08-08 07:51:54 UTC) #9
commit-bot: I haz the power
Try job failure for 10836149-8001 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-08 14:56:23 UTC) #10
navabi
On 2012/08/08 14:56:23, I haz the power (commit-bot) wrote: > Try job failure for 10836149-8001 ...
8 years, 4 months ago (2012-08-08 16:52:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@chromium.org/10836149/12002
8 years, 4 months ago (2012-08-08 19:08:12 UTC) #12
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 21:27:41 UTC) #13
Change committed as 150614

Powered by Google App Engine
This is Rietveld 408576698