Issue 10836136: fix a copy&paste error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836136: fix a copy&paste error. (Closed)

Created:
8 years, 4 months ago by wjia(left Chromium)

Modified:
8 years, 4 months ago

Reviewers:
Ami GONE FROM CHROMIUM, scherkus (not reviewing)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

fix a copy&paste error. MediaStreamDispatcher::OnDevicesEnumerationFailed() should call request.handler->OnDevicesEnumerationFailed(), instead of request.handler->OnStreamGenerationFailed(). BUG=140968 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150399

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/media/media_stream_dispatcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM OOC why didn't any tests catch this?

8 years, 4 months ago (2012-08-07 21:01:16 UTC) #2

wjia(left Chromium)

8 years, 4 months ago (2012-08-07 21:02:26 UTC) #3

On 2012/08/07 21:01:16, scherkus wrote:
> LGTM
> 
> OOC why didn't any tests catch this?

Thanks! There is no test for failed case so far. Should have that when have
time.

Expand Messages | Collapse Messages