Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 10836133: Inline simple setter calls. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added comment. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 ? DefineDeoptimizationLiteral(environment->closure()) 486 ? DefineDeoptimizationLiteral(environment->closure())
487 : Translation::kSelfLiteralId; 487 : Translation::kSelfLiteralId;
488 488
489 switch (environment->frame_type()) { 489 switch (environment->frame_type()) {
490 case JS_FUNCTION: 490 case JS_FUNCTION:
491 translation->BeginJSFrame(environment->ast_id(), closure_id, height); 491 translation->BeginJSFrame(environment->ast_id(), closure_id, height);
492 break; 492 break;
493 case JS_CONSTRUCT: 493 case JS_CONSTRUCT:
494 translation->BeginConstructStubFrame(closure_id, translation_size); 494 translation->BeginConstructStubFrame(closure_id, translation_size);
495 break; 495 break;
496 case JS_SETTER:
497 // TODO(svenpanne) Implement me!
498 break;
496 case ARGUMENTS_ADAPTOR: 499 case ARGUMENTS_ADAPTOR:
497 translation->BeginArgumentsAdaptorFrame(closure_id, translation_size); 500 translation->BeginArgumentsAdaptorFrame(closure_id, translation_size);
498 break; 501 break;
499 default:
500 UNREACHABLE();
501 } 502 }
502 for (int i = 0; i < translation_size; ++i) { 503 for (int i = 0; i < translation_size; ++i) {
503 LOperand* value = environment->values()->at(i); 504 LOperand* value = environment->values()->at(i);
504 // spilled_registers_ and spilled_double_registers_ are either 505 // spilled_registers_ and spilled_double_registers_ are either
505 // both NULL or both set. 506 // both NULL or both set.
506 if (environment->spilled_registers() != NULL && value != NULL) { 507 if (environment->spilled_registers() != NULL && value != NULL) {
507 if (value->IsRegister() && 508 if (value->IsRegister() &&
508 environment->spilled_registers()[value->index()] != NULL) { 509 environment->spilled_registers()[value->index()] != NULL) {
509 translation->MarkDuplicate(); 510 translation->MarkDuplicate();
510 AddToTranslation(translation, 511 AddToTranslation(translation,
(...skipping 5015 matching lines...) Expand 10 before | Expand all | Expand 10 after
5526 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize)); 5527 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize));
5527 __ ldr(result, FieldMemOperand(scratch, 5528 __ ldr(result, FieldMemOperand(scratch,
5528 FixedArray::kHeaderSize - kPointerSize)); 5529 FixedArray::kHeaderSize - kPointerSize));
5529 __ bind(&done); 5530 __ bind(&done);
5530 } 5531 }
5531 5532
5532 5533
5533 #undef __ 5534 #undef __
5534 5535
5535 } } // namespace v8::internal 5536 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698