Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 10836132: Force eager compilation of parenthesized functions. (Closed)

Created:
8 years, 4 months ago by Michael Starzinger
Modified:
8 years, 4 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Force eager compilation of parenthesized functions. This makes the compiler use eager compilation for function literals that are parenthesized. We consider this to be a hint that the function will be called immediatly and hence try to avoid parsing it twice. The parser already respects this heuristic. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12270

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -13 lines) Patch
M src/ast.h View 6 chunks +18 lines, -4 lines 2 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.h View 1 chunk +14 lines, -1 line 0 comments Download
M src/parser.cc View 7 chunks +13 lines, -6 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
https://chromiumcodereview.appspot.com/10836132/diff/1/src/ast.h File src/ast.h (right): https://chromiumcodereview.appspot.com/10836132/diff/1/src/ast.h#newcode2035 src/ast.h:2035: enum IsParenthesizedFlag { I am torn between "IsParenthesizedFlag" and ...
8 years, 4 months ago (2012-08-07 12:58:51 UTC) #1
ulan
8 years, 4 months ago (2012-08-07 13:18:33 UTC) #2
LGTM

https://chromiumcodereview.appspot.com/10836132/diff/1/src/ast.h
File src/ast.h (right):

https://chromiumcodereview.appspot.com/10836132/diff/1/src/ast.h#newcode2035
src/ast.h:2035: enum IsParenthesizedFlag {
On 2012/08/07 12:58:51, Michael Starzinger wrote:
> I am torn between "IsParenthesizedFlag" and just "ParenthesizedFlag", WDYT?
I like IsParenthesizedFlag more.

Powered by Google App Engine
This is Rietveld 408576698