Issue 10836130: Update the webdriver_pages to use "list" instead of "listbox". - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(670)

My Issues | Starred Open | Closed | All

Issue 10836130: Update the webdriver_pages to use "list" instead of "listbox". (Closed)

Created:
8 years, 4 months ago by Joao da Silva

Modified:
8 years, 4 months ago

Reviewers:
kkania, Mattias Nissler (ping if slow), Nirnimesh

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh, Mattias Nissler (ping if slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update the webdriver_pages to use "list" instead of "listbox". This was broken by https://chromiumcodereview.appspot.com/10376003/diff/37016/chrome/browser/resources/shared/js/cr/ui/list.js, and broke the prefs_ui.py pyauto tests. TBR=nirnimesh@chromium.org,kkania@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150325

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/test/functional/webdriver_pages/settings.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

LGTM to commit in order to fix up the PyAuto waterfall

8 years, 4 months ago (2012-08-07 11:05:06 UTC) #2

Thanks for the fix. LGTM

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698