Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 10836127: Fix outdated documentation on blocking start and handling of synchronous requests (Closed)

Created:
8 years, 4 months ago by battre
Modified:
8 years, 4 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Fix outdated documentation on blocking start and handling of synchronous requests BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150341

Patch Set 1 #

Patch Set 2 : Updated to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M chrome/common/extensions/docs/examples/api/notifications.zip View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/extensions/webRequest.html View 1 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/webRequest.html View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
PTAL. Thx, Dominic
8 years, 4 months ago (2012-08-07 08:27:49 UTC) #1
Aaron Boodman
lgtm
8 years, 4 months ago (2012-08-07 13:37:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10836127/1
8 years, 4 months ago (2012-08-07 13:58:38 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 13:58:41 UTC) #4
Presubmit check for 10836127-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to chrome/common/extensions/docs/static/webRequest.html not reflected
in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py --page-name=<apiName>

Presubmit checks took 1.2s to calculate.

Powered by Google App Engine
This is Rietveld 408576698