Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 10836116: Purge ImplementsThreadSafeReferenceCounting() from the codebase now that Task is dead. (Closed)

Created:
8 years, 4 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright (departed), amit, brettw-cc_chromium.org, jam, gavinp+memory_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, robertshield, grt+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Purge ImplementsThreadSafeReferenceCounting() from the codebase now that Task is dead. TBR=ananta@chromium.org,apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150202

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -68 lines) Patch
M base/memory/ref_counted.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/base/view_event_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/chrome_frame_activex_base.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome_frame/test/ie_event_sink.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome_frame/test/url_request_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome_frame/urlmon_url_request_private.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/browser_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/share_group.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D gpu/command_buffer/client/share_group_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M gpu/gpu_common.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/include/ref_counted.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ami GONE FROM CHROMIUM
AFAICT now that we live in a glorious post-Task world, ImplementsThreadSafeReferenceCounting() (added in http://crrev.com/27379) is ...
8 years, 4 months ago (2012-08-06 18:43:54 UTC) #1
awong
LGTM
8 years, 4 months ago (2012-08-06 18:56:23 UTC) #2
darin (slow to review)
yay, LGTM
8 years, 4 months ago (2012-08-06 20:40:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10836116/1
8 years, 4 months ago (2012-08-06 20:42:51 UTC) #4
commit-bot: I haz the power
Presubmit check for 10836116-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-06 20:42:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10836116/1
8 years, 4 months ago (2012-08-06 20:49:22 UTC) #6
commit-bot: I haz the power
Try job failure for 10836116-1 (retry) on win_rel for step "runhooks". It's a second try, ...
8 years, 4 months ago (2012-08-06 22:07:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10836116/1015
8 years, 4 months ago (2012-08-06 22:19:48 UTC) #8
commit-bot: I haz the power
Try job failure for 10836116-1015 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 22:57:28 UTC) #9
awong
commit-bot hates you. On Mon, Aug 6, 2012 at 3:57 PM, <commit-bot@chromium.org> wrote: > Try ...
8 years, 4 months ago (2012-08-06 22:58:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10836116/1015
8 years, 4 months ago (2012-08-06 23:12:18 UTC) #11
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 00:59:46 UTC) #12
Change committed as 150202

Powered by Google App Engine
This is Rietveld 408576698