Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 10836111: remove an unnecessary divider line (Closed)

Created:
8 years, 4 months ago by no longer working on chromium
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

NOTRY=true BUG=139978 Test= manual, go to https://apprtc.appspot.com and make sure there is no divider line at the top of the drop down options menu. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/infobars/media_stream_infobar_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
no longer working on chromium
shess, can I get your owner stamp to land this tiny fix? Thanks, BR; -SX
8 years, 4 months ago (2012-08-06 13:46:07 UTC) #1
Scott Hess - ex-Googler
LGTM, except I think that "remove an unnecessary divider line" is a needlessly concise commit ...
8 years, 4 months ago (2012-08-06 19:09:54 UTC) #2
no longer working on chromium
On 2012/08/06 19:09:54, shess wrote: > LGTM, except I think that "remove an unnecessary divider ...
8 years, 4 months ago (2012-08-06 19:55:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/10836111/1
8 years, 4 months ago (2012-08-06 19:55:37 UTC) #4
commit-bot: I haz the power
Try job failure for 10836111-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 20:26:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/10836111/1
8 years, 4 months ago (2012-08-06 21:59:47 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 22:26:36 UTC) #7
Change committed as 150158

Powered by Google App Engine
This is Rietveld 408576698