Issue 10836105: Implement favicon.ico variant selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836105: Implement favicon.ico variant selection. (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
pkotwicz, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement favicon.ico variant selection. Not used anywhere yet. BUG=138550 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150091

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+313 lines, -0 lines)			Patch
A	chrome/browser/favicon/select_favicon_frames.h	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	chrome/browser/favicon/select_favicon_frames.cc	View	1 chunk	+115 lines, -0 lines	1 comment	Download
A	chrome/browser/favicon/select_favicon_frames_unittest.cc	View	1 chunk	+168 lines, -0 lines	1 comment	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

8 years, 4 months ago (2012-08-06 15:05:08 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10836105/diff/1/chrome/browser/favicon...
File chrome/browser/favicon/select_favicon_frames.cc (right):

https://chromiumcodereview.appspot.com/10836105/diff/1/chrome/browser/favicon...
chrome/browser/favicon/select_favicon_frames.cc:28: const std::vector<SkBitmap>&
bitmaps, int desired_size) {
wrap destired_size to next line.

https://chromiumcodereview.appspot.com/10836105/diff/1/chrome/browser/favicon...
File chrome/browser/favicon/select_favicon_frames_unittest.cc (right):

https://chromiumcodereview.appspot.com/10836105/diff/1/chrome/browser/favicon...
chrome/browser/favicon/select_favicon_frames_unittest.cc:36: SkColor
GetColor(const gfx::ImageSkia& image, ui::ScaleFactor factor,
nit: each param on its own line and no default values.

Expand Messages | Collapse Messages