Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 10836102: Spruce up gmail checker for event pages. (Closed)

Created:
8 years, 4 months ago by Aaron Boodman
Modified:
8 years, 4 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, not at google - send to devlin
Visibility:
Public.

Description

Spruce up gmail checker for event pages. - Use filtered web navigation instead of tabs.onUpdated to reduce amount of event page launching. - Don't show loading animation for alarm-triggered or tab-triggered requests to reduce distraction. - Don't schedule a new request on each event page load. - Fix options page for CSP - Make options page actually work (it had several bugs) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150243

Patch Set 1 #

Patch Set 2 : monkey! #

Patch Set 3 : Add default icon #

Patch Set 4 : hate hate hate #

Patch Set 5 : full to the brim of hate #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -63 lines) Patch
M chrome/common/extensions/docs/examples/extensions/gmail.zip View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/background.js View 1 5 chunks +54 lines, -37 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/manifest.json View 1 2 3 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/options.js View 3 chunks +11 lines, -6 lines 1 comment Download
M chrome/common/extensions/docs/extensions/samples.html View 1 2 3 4 4 chunks +14 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 3 4 4 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Aaron Boodman
8 years, 4 months ago (2012-08-04 15:59:10 UTC) #1
Matt Perry
Cool! LGTM
8 years, 4 months ago (2012-08-06 20:18:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10836102/9001
8 years, 4 months ago (2012-08-07 01:46:13 UTC) #3
not at google - send to devlin
https://chromiumcodereview.appspot.com/10836102/diff/9001/chrome/common/extensions/docs/examples/extensions/gmail/options.js File chrome/common/extensions/docs/examples/extensions/gmail/options.js (right): https://chromiumcodereview.appspot.com/10836102/diff/9001/chrome/common/extensions/docs/examples/extensions/gmail/options.js#newcode19 chrome/common/extensions/docs/examples/extensions/gmail/options.js:19: localStorage.customDomain = customDomainsTextbox.value; use storage.sync?
8 years, 4 months ago (2012-08-07 02:48:32 UTC) #4
not at google - send to devlin
8 years, 4 months ago (2012-08-07 02:49:17 UTC) #5
oops didn't mean to add myself as a reviewer or anything, was just reading the
commit log out of curiosity and noticed that.

Powered by Google App Engine
This is Rietveld 408576698