Issue 10836100: Fixing race condition on banner showing code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836100: Fixing race condition on banner showing code. (Closed)

Created:
8 years, 4 months ago by SeRya

Modified:
8 years, 4 months ago

Reviewers:
Vladislav Kaznacheev, Dmitry Zvorygin

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing race condition on banner showing code. Most likely it causes the bug bacause it the only code path I found that show the banner relying on potentially outdated current directory check. BUG=140119 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150298

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10836100/1

8 years, 4 months ago (2012-08-06 16:52:12 UTC) #3

commit-bot: I haz the power

Try job failure for 10836100-1 (retry) on win_rel for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-06 17:07:35 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10836100/1

8 years, 4 months ago (2012-08-07 05:42:46 UTC) #5

Change committed as 150298

Expand Messages | Collapse Messages