Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Unified Diff: chrome/common/extensions/extension.h

Issue 10836088: Make the manifest_ member of Extension into a scoped_ptr. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 8c9f83b7625261c59fc0d0fb830df87a549d6b70..37305b40280ae73f946ee1186ab53bdb50b61e6a 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -662,7 +662,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
const GURL& update_url() const { return update_url_; }
const ExtensionIconSet& icons() const { return icons_; }
const extensions::Manifest* manifest() const {
- return manifest_;
+ return manifest_.get();
}
const std::string default_locale() const { return default_locale_; }
const URLOverrideMap& GetChromeURLOverrides() const {
@@ -1068,15 +1068,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
GURL update_url_;
// The manifest from which this extension was created.
- //
- // NOTE: This is an owned pointer, but can't use scoped_ptr because that would
- // require manifest.h, which would in turn create a circulate dependency
- // between extension.h and manifest.h.
- //
- // TODO(aa): Pull Extension::Type and Extension::Location out into their own
- // files so that manifest.h can rely on them and not get all of extension.h
- // too, and then change this back to a scoped_ptr.
- extensions::Manifest* manifest_;
+ scoped_ptr<Manifest> manifest_;
// A map of chrome:// hostnames (newtab, downloads, etc.) to Extension URLs
// which override the handling of those URLs. (see ExtensionOverrideUI).
« no previous file with comments | « no previous file | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698