Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 10836088: Make the manifest_ member of Extension into a scoped_ptr. (Closed)

Created:
8 years, 4 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 4 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Make the manifest_ member of Extension into a scoped_ptr. Forwarded declared classes can be used as template parameters. R=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M chrome/common/extensions/extension.h View 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/common/extensions/extension.cc View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mihai Parparita -not on Chrome
8 years, 4 months ago (2012-08-02 23:50:11 UTC) #1
Aaron Boodman
Hm, I thought this didn't work for me, but ok. lgtm.
8 years, 4 months ago (2012-08-06 03:07:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10836088/1
8 years, 4 months ago (2012-08-06 17:34:15 UTC) #3
commit-bot: I haz the power
Try job failure for 10836088-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 17:52:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10836088/1
8 years, 4 months ago (2012-08-06 18:17:33 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 19:44:47 UTC) #6
Change committed as 150130

Powered by Google App Engine
This is Rietveld 408576698