[Mac] Make entering system fullscreen from presentation mode possible.

[Mac] Make entering system fullscreen from presentation mode possible.

This makes {{Enter,Exit} {Presentaiton Mode,Fullscreen}} symmetric, per
https://docs.google.com/open?id=0B4kReKV-OI17Y1lscGhISEtCYjg

BUG=114373
TEST=The actions in the above diagram work.
TBR=yzshen

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150219

[scheib, 2012-08-03 02:45:58]

https://chromiumcodereview.appspot.com/10836086/diff/1/chrome/browser/ui/full...
File chrome/browser/ui/fullscreen/fullscreen_controller.cc (right):

https://chromiumcodereview.appspot.com/10836086/diff/1/chrome/browser/ui/full...
chrome/browser/ui/fullscreen/fullscreen_controller.cc:508: #if
defined(OS_MACOSX)
The #if MAC sections in this file make the logic confusing. Not necessarily with
this change, but in the current Mac full screen clean up effort, can we reduce
the platform #if defs in this file?

[Robert Sesek, 2012-08-03 14:44:08]

https://chromiumcodereview.appspot.com/10836086/diff/1/chrome/browser/ui/full...
File chrome/browser/ui/fullscreen/fullscreen_controller.cc (right):

https://chromiumcodereview.appspot.com/10836086/diff/1/chrome/browser/ui/full...
chrome/browser/ui/fullscreen/fullscreen_controller.cc:508: #if
defined(OS_MACOSX)
On 2012/08/03 02:45:58, scheib wrote:
> The #if MAC sections in this file make the logic confusing. Not necessarily
with
> this change, but in the current Mac full screen clean up effort, can we reduce
> the platform #if defs in this file?

Yes, that's something I want to do. I think most of the logic in this file is
generally confusing, I just wanted to get the behavior right for M22.

[Robert Sesek, 2012-08-03 19:14:36]

Rohit: ping?

[rohitrao (ping after 24h), 2012-08-03 19:49:35]

I didn't follow the logic of why this change actually works.  Was hoping to chat
with you so you could explain it to me.

[rohitrao (ping after 24h), 2012-08-06 18:20:42]

lgtm

[commit-bot: I haz the power, 2012-08-06 20:51:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/10836086/1

[commit-bot: I haz the power, 2012-08-06 20:51:40]

Presubmit check for 10836086-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/fullscreen

[commit-bot: I haz the power, 2012-08-06 20:52:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/10836086/1

[commit-bot: I haz the power, 2012-08-06 22:21:00]

Try job failure for 10836086-1 (retry) (previous was lost) on linux_rel for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-06 23:30:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/10836086/1

[commit-bot: I haz the power, 2012-08-06 23:39:55]

Try job failure for 10836086-1 on linux_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-06 23:41:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/10836086/1

[commit-bot: I haz the power, 2012-08-07 01:27:09]

Change committed as 150219