SPDY - Handle incomplete headers during server push.

net/http/http_network_transaction.cc

Index: net/http/http_network_transaction.cc
===================================================================
--- net/http/http_network_transaction.cc	(revision 149736)
+++ net/http/http_network_transaction.cc	(working copy)
@@ -260,7 +260,8 @@
   bool keep_alive = false;
   // Even if the server says the connection is keep-alive, we have to be
   // able to find the end of each response in order to reuse the connection.
-  if (GetResponseHeaders()->IsKeepAlive() &&
+  HttpResponseHeaders* headers = GetResponseHeaders();
+  if (headers && headers->IsKeepAlive() &&

[Ryan Hamilton, 2012/08/03 19:52:14]

Is this change related to the SPDY server push bug?  If not, I think it should
be split into a new CL.

Either way, it would be great if there were a test.

[ramant (doing other things), 2012/08/03 20:50:40]

Deleted this change.

       stream_->CanFindEndOfResponse()) {
     // If the response body hasn't been completely read, we need to drain
     // it first.
@@ -920,8 +921,11 @@
     // TODO(mbelshe): The keepalive property is really a property of
     //    the stream.  No need to compute it here just to pass back
     //    to the stream's Close function.
-    if (stream_->CanFindEndOfResponse())
-      keep_alive = GetResponseHeaders()->IsKeepAlive();
+    if (stream_->CanFindEndOfResponse()) {
+      HttpResponseHeaders* headers = GetResponseHeaders();

[Ryan Hamilton, 2012/08/03 19:52:14]

(Ditto)

[ramant (doing other things), 2012/08/03 20:50:40]

SpdyNetworkTransactionSpdy3Test..ServerPushWithNoStatusHeaderFrames causes this
crash. It looks like CanFindEndOfResponse is being true though there are no
response headers. That may be another bug. Will undo this change when we fix it.
Added a TODO. Will submit a separate CL for unit tests.

[Ryan Hamilton, 2012/08/03 21:10:01]

Does that test cause a crash with your new code, or with the new code.  If your
new test is crashing here with the new code, then I agree with you that this
change is required as part of this CL.

+      if (headers)
+        keep_alive = headers->IsKeepAlive();
+    }
   }
 
   // Clean up connection if we are done.