Issue 10836075: [Chromoting] Let the Mac host policy watcher read string-valued policies.

Issue 10836075: [Chromoting] Let the Mac host policy watcher read string-valued policies. (Closed)

Created:
8 years, 4 months ago by dcaiafa

Modified:
8 years, 4 months ago

Reviewers:
simonmorris

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Chromoting] Let the Mac host policy watcher read string-valued policies. BUG=132864 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149675

Patch Set 1 #

Patch Set 2 : Replaced string conv. boilerplate with base func call.w #

Total comments: 2

Patch Set 3 : Use CFCast #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
	M	remoting/host/policy_hack/policy_watcher_mac.mm	View	1 2	2 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

simonmorris

lgtm with an optional suggestion http://codereview.chromium.org/10836075/diff/3001/remoting/host/policy_hack/policy_watcher_mac.mm File remoting/host/policy_hack/policy_watcher_mac.mm (right): http://codereview.chromium.org/10836075/diff/3001/remoting/host/policy_hack/policy_watcher_mac.mm#newcode68 remoting/host/policy_hack/policy_watcher_mac.mm:68: property_list.get()); Is it worth ...

8 years, 4 months ago (2012-08-02 16:48:22 UTC) #2

dcaiafa

FYI http://codereview.chromium.org/10836075/diff/3001/remoting/host/policy_hack/policy_watcher_mac.mm File remoting/host/policy_hack/policy_watcher_mac.mm (right): http://codereview.chromium.org/10836075/diff/3001/remoting/host/policy_hack/policy_watcher_mac.mm#newcode68 remoting/host/policy_hack/policy_watcher_mac.mm:68: property_list.get()); On 2012/08/02 16:48:22, simonmorris wrote: > Is ...

8 years, 4 months ago (2012-08-02 17:49:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/10836075/4001

8 years, 4 months ago (2012-08-02 17:52:07 UTC) #4

Change committed as 149675

Expand Messages | Collapse Messages