Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 10836063: Add deletion test, cursor read with writeback to same store. (Closed)

Created:
8 years, 4 months ago by ericu
Modified:
8 years, 4 months ago
Reviewers:
jsbell
CC:
chromium-reviews, alecflett, dgrogan
Visibility:
Public.

Description

Add deletion timing test. Add a cursor-read-random-write test that writes back to the same store. Turn on database deletion for all other perf tests [although the time's not counted for tests other than the deletion test]. BUG=137764 TEST=self Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149659

Patch Set 1 #

Patch Set 2 : Add bug number. #

Total comments: 2

Patch Set 3 : Close databases, then actually delete them. #

Patch Set 4 : Add onblocked handler for deleteDatabase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -23 lines) Patch
M chrome/test/data/indexeddb/perf_shared.js View 1 2 3 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/test/data/indexeddb/perf_test.js View 1 2 9 chunks +90 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ericu
8 years, 4 months ago (2012-08-01 22:56:39 UTC) #1
jsbell
https://chromiumcodereview.appspot.com/10836063/diff/2001/chrome/test/data/indexeddb/perf_test.js File chrome/test/data/indexeddb/perf_test.js (right): https://chromiumcodereview.appspot.com/10836063/diff/2001/chrome/test/data/indexeddb/perf_test.js#newcode140 chrome/test/data/indexeddb/perf_test.js:140: deleteDatabase(testName, onDeleted); Need to call db.close() before deleteDatabase() or ...
8 years, 4 months ago (2012-08-01 23:05:26 UTC) #2
ericu
https://chromiumcodereview.appspot.com/10836063/diff/2001/chrome/test/data/indexeddb/perf_test.js File chrome/test/data/indexeddb/perf_test.js (right): https://chromiumcodereview.appspot.com/10836063/diff/2001/chrome/test/data/indexeddb/perf_test.js#newcode140 chrome/test/data/indexeddb/perf_test.js:140: deleteDatabase(testName, onDeleted); On 2012/08/01 23:05:26, jsbell wrote: > Need ...
8 years, 4 months ago (2012-08-01 23:39:43 UTC) #3
ericu
And fixed the close/deletion problem, and now it's all happy.
8 years, 4 months ago (2012-08-01 23:40:17 UTC) #4
jsbell
lgtm
8 years, 4 months ago (2012-08-02 04:38:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/10836063/3003
8 years, 4 months ago (2012-08-02 17:00:01 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 18:43:17 UTC) #7
Change committed as 149659

Powered by Google App Engine
This is Rietveld 408576698