Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10836057: Change RPH location bar icon to use web intents logo. (Closed)

Created:
8 years, 4 months ago by Greg Billock
Modified:
8 years, 4 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Change RPH location bar icon to use web intents logo. R=cpu@chromium.org BUG=122020 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149813

Patch Set 1 #

Patch Set 2 : Merge to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
D chrome/app/theme/default_100_percent/register_protocol_handler_locationbar_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/default_100_percent/webintents.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Greg Billock
8 years, 4 months ago (2012-08-01 17:58:08 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
8 years, 4 months ago (2012-08-01 19:40:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10836057/1
8 years, 4 months ago (2012-08-01 20:23:34 UTC) #3
commit-bot: I haz the power
Try job failure for 10836057-1 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=44443 Step "update" is always ...
8 years, 4 months ago (2012-08-01 20:25:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10836057/6003
8 years, 4 months ago (2012-08-02 15:01:58 UTC) #5
commit-bot: I haz the power
Try job failure for 10836057-6003 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=44638 Step "update" is always ...
8 years, 4 months ago (2012-08-02 15:03:51 UTC) #6
Greg Billock
cpu, any idea why this keeps failing mac update? Is there something special I need ...
8 years, 4 months ago (2012-08-02 19:27:37 UTC) #7
cpu_(ooo_6.6-7.5)
it says /usr/bin/patch: **** malformed patch at line 14: The patch itself looks strage.
8 years, 4 months ago (2012-08-02 23:59:45 UTC) #8
Greg Billock
On 2012/08/02 23:59:45, cpu wrote: > it says > /usr/bin/patch: **** malformed patch at line ...
8 years, 4 months ago (2012-08-03 07:21:23 UTC) #9
cpu_(ooo_6.6-7.5)
No idea. If you want to dcommit please log into the irc channel and give ...
8 years, 4 months ago (2012-08-03 20:31:45 UTC) #10
Greg Billock
8 years, 4 months ago (2012-08-03 21:06:47 UTC) #11
Done and committed
On Aug 3, 2012 1:31 PM, <cpu@chromium.org> wrote:

> No idea. If you want to dcommit please log into the irc channel and give a
> heads
> up to the sheriff.
>
>
https://chromiumcodereview.**appspot.com/10836057/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698