Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chromeos/dbus/ibus/ibus_engine_factory_service.h

Issue 10836047: Revise IBus related DBus module. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Style fix Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/ibus/ibus_engine_factory_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/ibus/ibus_engine_factory_service.h
diff --git a/chromeos/dbus/ibus/ibus_engine_factory_service.h b/chromeos/dbus/ibus/ibus_engine_factory_service.h
index 43f2dd8f65ae398bc87b188077aea06497493ce6..ccafde086fad5e7be4dde38b9737387592bad99b 100644
--- a/chromeos/dbus/ibus/ibus_engine_factory_service.h
+++ b/chromeos/dbus/ibus/ibus_engine_factory_service.h
@@ -5,6 +5,7 @@
#ifndef CHROMEOS_DBUS_IBUS_IBUS_ENGINE_FACTORY_SERVICE_H_
#define CHROMEOS_DBUS_IBUS_IBUS_ENGINE_FACTORY_SERVICE_H_
+#include <string>
#include "base/bind.h"
#include "base/callback.h"
#include "chromeos/chromeos_export.h"
@@ -22,20 +23,22 @@ namespace chromeos {
// service if the extension IME is enabled.
class CHROMEOS_EXPORT IBusEngineFactoryService {
public:
- // The CreateEngine message accepts |engine_id| which identifies the engine
- // module(ex. "mozc"), and returns an ObjectPath. The ibus-daemon will send
- // dbus message to returned ObjectPath for engine processing.
- typedef base::Callback<dbus::ObjectPath (const std::string& engine_id)>
+ typedef base::Callback<void(const dbus::ObjectPath& path)>
+ CreateEngineResponseSender;
+ typedef base::Callback<void(const CreateEngineResponseSender& sender)>
CreateEngineHandler;
virtual ~IBusEngineFactoryService();
- // Sets CreateEngine method call handler.
+ // Sets CreateEngine method call handler for |engine_id|. If ibus-daemon calls
+ // CreateEngine message with |engine_id|, the |create_engine_handler| will be
+ // called.
virtual void SetCreateEngineHandler(
+ const std::string& engine_id,
const CreateEngineHandler& create_engine_handler) = 0;
- // Unsets CreateEngine method call handler.
- virtual void UnsetCreateEngineHandler() = 0;
+ // Unsets CreateEngine method call handler for |engine_id|.
+ virtual void UnsetCreateEngineHandler(const std::string& engine_id) = 0;
// Factory function, creates a new instance and returns ownership.
// For normal usage, accesses the sigleton via DBusThreadManager::Get().
« no previous file with comments | « no previous file | chromeos/dbus/ibus/ibus_engine_factory_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698