Valgrind: Fix some leaks and style issues in NetInternalsUI.

Valgrind: Fix some leaks and style issues in NetInternalsUI.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149560

[mmenke, 2012-08-01 07:44:49]

Driveby comment:  Having every function delete its argument itself seems much
more leak prone than just using base::Owned.

[Lei Zhang, 2012-08-01 08:32:05]

On 2012/08/01 07:44:49, Matt Menke wrote:
> Driveby comment:  Having every function delete its argument itself seems much
> more leak prone than just using base::Owned.

Thanks, see patch set 2.

I think that can work, as long as all the callees follow the convention and
don't try to do things like pass |list| into SendJavascriptCommand(). Nobody
does that right now. I've added an additional comment.

[eroman, 2012-08-01 23:10:05]

LGTM, thanks for fixing this!

https://chromiumcodereview.appspot.com/10836045/diff/9002/chrome/browser/ui/w...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://chromiumcodereview.appspot.com/10836045/diff/9002/chrome/browser/ui/w...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:495: void
DispatchToMessageHandler(ListValue* arg, MessageHandler method);
Delete this, it is dead code.

https://chromiumcodereview.appspot.com/10836045/diff/9002/chrome/browser/ui/w...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:874: // thread. We
will delete |list| in IOThreadImpl::DispatchToMessageHandler().
Remove the reference to DispatchToMessageHandler. In fact, it looks like this
was the source of the problem: r104422 removed the indirection through
DispatchToMessageHandler which was deleting the copy of the argument!

https://chromiumcodereview.appspot.com/10836045/diff/9002/chrome/browser/ui/w...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:875: // |list_copy|
will deleted when the task is destroyed. The called |method|
"will deleted" --> "will be deleted"

https://chromiumcodereview.appspot.com/10836045/diff/9002/chrome/browser/ui/w...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:1584: void
NetInternalsMessageHandler::IOThreadImpl::DispatchToMessageHandler(
Delete this, it is dead code.

[Lei Zhang, 2012-08-02 00:38:47]

Dead code removed.

[commit-bot: I haz the power, 2012-08-02 00:39:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10836045/6003

[commit-bot: I haz the power, 2012-08-02 01:56:00]

Change committed as 149560