Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 10836044: ppapi NaCl trusted plugin: Rename interface because Win build breaks on it. (Closed)

Created:
8 years, 4 months ago by binji
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

ppapi NaCl trusted plugin: Rename interface because Win build breaks on it. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
binji
#including <windows.h> will #define interface -> __STRUCT__ -> struct. :-(
8 years, 4 months ago (2012-08-01 05:28:20 UTC) #1
binji
On 2012/08/01 05:28:20, binji wrote: > #including <windows.h> will #define interface -> __STRUCT__ -> struct. ...
8 years, 4 months ago (2012-08-01 05:29:02 UTC) #2
Derek Schuff
lgtm wow. just... wow.
8 years, 4 months ago (2012-08-01 15:51:58 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-08-01 15:52:43 UTC) #4
Derek Schuff
On 2012/08/01 15:51:58, dschuff wrote: > lgtm > > wow. just... wow. so... why doesn't ...
8 years, 4 months ago (2012-08-01 15:52:52 UTC) #5
binji
+jvoung for OWNER/committer
8 years, 4 months ago (2012-08-01 17:26:57 UTC) #6
jvoung (off chromium)
lgtm (!?!)
8 years, 4 months ago (2012-08-01 17:29:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10836044/1
8 years, 4 months ago (2012-08-01 17:34:49 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 18:58:02 UTC) #9
Change committed as 149454

Powered by Google App Engine
This is Rietveld 408576698