Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 10836037: Start in extended desktop mode if it is enabled. (Closed)

Created:
8 years, 4 months ago by rkc
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Start in extended desktop mode if it is enabled. Currently we start in mirrored mode by default every time; change this so that if the extended desktop is enabled, we default to that instead. R=sky@chromium.org BUG=138093 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149342

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/display/output_configurator.h View 1 3 chunks +5 lines, -2 lines 0 comments Download
M chromeos/display/output_configurator.cc View 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rkc
8 years, 4 months ago (2012-07-31 22:23:17 UTC) #1
sky
https://chromiumcodereview.appspot.com/10836037/diff/1/ash/shell.cc File ash/shell.cc (right): https://chromiumcodereview.appspot.com/10836037/diff/1/ash/shell.cc#newcode183 ash/shell.cc:183: output_configurator_(new chromeos::OutputConfigurator( Is there a reason why OutputConfigurator can't ...
8 years, 4 months ago (2012-07-31 23:16:28 UTC) #2
rkc1
https://chromiumcodereview.appspot.com/10836037/diff/1/ash/shell.cc File ash/shell.cc (right): https://chromiumcodereview.appspot.com/10836037/diff/1/ash/shell.cc#newcode183 ash/shell.cc:183: output_configurator_(new chromeos::OutputConfigurator( On 2012/07/31 23:16:28, sky wrote: > Is ...
8 years, 4 months ago (2012-07-31 23:34:03 UTC) #3
sky
LGTM https://chromiumcodereview.appspot.com/10836037/diff/1/chromeos/display/output_configurator.h File chromeos/display/output_configurator.h (right): https://chromiumcodereview.appspot.com/10836037/diff/1/chromeos/display/output_configurator.h#newcode135 chromeos/display/output_configurator.h:135: bool is_extended_display_enabled_; const
8 years, 4 months ago (2012-07-31 23:42:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10836037/7001
8 years, 4 months ago (2012-07-31 23:57:00 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 01:07:02 UTC) #6
Change committed as 149342

Powered by Google App Engine
This is Rietveld 408576698