Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: media/audio/audio_output_device.h

Issue 10836025: Part 1: Plumb render view ID to render host (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_device.h
diff --git a/media/audio/audio_output_device.h b/media/audio/audio_output_device.h
index 0e70ceb46c5c2e4e4336db3db915ae3262f5813f..1b7231b09cf2b46ea833c6268a2e2c27c533d00b 100644
--- a/media/audio/audio_output_device.h
+++ b/media/audio/audio_output_device.h
@@ -95,9 +95,7 @@ class MEDIA_EXPORT AudioOutputDevice
virtual void OnIPCClosed() OVERRIDE;
// Creates an uninitialized AudioOutputDevice. Clients must call Initialize()
- // before using.
- // TODO(tommi): When all dependencies on |content| have been removed
- // from AudioOutputDevice, move this class over to media/audio.
+ // before using. Takes ownership of |ipc|.
AudioOutputDevice(AudioOutputIPC* ipc,
const scoped_refptr<base::MessageLoopProxy>& io_loop);
@@ -128,7 +126,7 @@ class MEDIA_EXPORT AudioOutputDevice
// A pointer to the IPC layer that takes care of sending requests over to
// the AudioRendererHost.
- AudioOutputIPC* ipc_;
+ scoped_ptr<AudioOutputIPC> ipc_;
// Our stream ID on the message filter. Only accessed on the IO thread.
// Must only be modified on the IO thread.

Powered by Google App Engine
This is Rietveld 408576698