Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: content/renderer/media/audio_device_factory.h

Issue 10836025: Part 1: Plumb render view ID to render host (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_AUDIO_DEVICE_FACTORY_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_AUDIO_DEVICE_FACTORY_H_
6 #define CONTENT_RENDERER_MEDIA_AUDIO_DEVICE_FACTORY_H_ 6 #define CONTENT_RENDERER_MEDIA_AUDIO_DEVICE_FACTORY_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 10
11 namespace media { 11 namespace media {
12 class AudioInputDevice; 12 class AudioInputDevice;
13 class AudioRendererSink; 13 class AudioRendererSink;
14 } 14 }
15 15
16 namespace content { 16 namespace content {
17 17
18 // A factory for creating AudioRendererSinks. There is a global factory 18 // A factory for creating AudioRendererSinks. There is a global factory
19 // function that can be installed for the purposes of testing to provide 19 // function that can be installed for the purposes of testing to provide
20 // a specialized AudioRendererSink class. 20 // a specialized AudioRendererSink class.
21 class CONTENT_EXPORT AudioDeviceFactory { 21 class CONTENT_EXPORT AudioDeviceFactory {
22 public: 22 public:
23 // Creates an AudioRendererSink using the currently registered factory, 23 // Creates an AudioRendererSink using the currently registered factory,
24 // or the default one if no factory is registered. Ownership of the returned 24 // or the default one if no factory is registered. Ownership of the returned
25 // pointer will be passed to the caller. 25 // pointer will be passed to the caller.
26 static media::AudioRendererSink* NewOutputDevice(); 26 static media::AudioRendererSink* NewOutputDevice(
27 int render_view_id);
27 28
28 // TODO(henrika): Update AudioInputDevice to inherit from an interface 29 // TODO(henrika): Update AudioInputDevice to inherit from an interface
29 // similar to AudioRendererSink, but for input. Same for the callback 30 // similar to AudioRendererSink, but for input. Same for the callback
30 // interfaces. 31 // interfaces.
31 static media::AudioInputDevice* NewInputDevice(); 32 static media::AudioInputDevice* NewInputDevice();
tommi (sloooow) - chröme 2012/07/31 10:52:41 don't we need the same for input devices?
sail 2012/07/31 22:02:08 I don't need input devices for this feature. I can
32 33
33 protected: 34 protected:
34 AudioDeviceFactory(); 35 AudioDeviceFactory();
35 virtual ~AudioDeviceFactory(); 36 virtual ~AudioDeviceFactory();
36 37
37 // You can derive from this class and specify an implementation for these 38 // You can derive from this class and specify an implementation for these
38 // functions to provide alternate audio device implementations. 39 // functions to provide alternate audio device implementations.
39 // If the return value of either of these function is NULL, we fall back 40 // If the return value of either of these function is NULL, we fall back
40 // on the default implementation. 41 // on the default implementation.
41 virtual media::AudioRendererSink* CreateOutputDevice() = 0; 42 virtual media::AudioRendererSink* CreateOutputDevice() = 0;
tommi (sloooow) - chröme 2012/07/31 10:52:41 Also add the parameter to these two factory functi
sail 2012/07/31 22:02:08 Done.
42 virtual media::AudioInputDevice* CreateInputDevice() = 0; 43 virtual media::AudioInputDevice* CreateInputDevice() = 0;
43 44
44 private: 45 private:
45 // The current globally registered factory. This is NULL when we should 46 // The current globally registered factory. This is NULL when we should
46 // create the default AudioRendererSinks. 47 // create the default AudioRendererSinks.
47 static AudioDeviceFactory* factory_; 48 static AudioDeviceFactory* factory_;
48 49
49 DISALLOW_COPY_AND_ASSIGN(AudioDeviceFactory); 50 DISALLOW_COPY_AND_ASSIGN(AudioDeviceFactory);
50 }; 51 };
51 52
52 } // namespace content 53 } // namespace content
53 54
54 #endif // CONTENT_RENDERER_MEDIA_AUDIO_DEVICE_FACTORY_H_ 55 #endif // CONTENT_RENDERER_MEDIA_AUDIO_DEVICE_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698