Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: sync/internal_api/syncapi_unittest.cc

Issue 10836021: [Sync] Disable purge/configuration tests on windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/syncapi_unittest.cc
diff --git a/sync/internal_api/syncapi_unittest.cc b/sync/internal_api/syncapi_unittest.cc
index 7ac20d039e2711490446aedc16906440c0dc7dc3..3c0a1d538f9f3ea27f5e52864370d71d18c11425 100644
--- a/sync/internal_api/syncapi_unittest.cc
+++ b/sync/internal_api/syncapi_unittest.cc
@@ -2559,6 +2559,12 @@ class SyncManagerTestWithMockScheduler : public SyncManagerTest {
// Test that the configuration params are properly created and sent to
// ScheduleConfigure. No callback should be invoked. Any disabled datatypes
// should be purged.
+// Fails on Windows: crbug.com/139726
+#if defined(OS_WIN)
+#define MAYBE_BasicConfiguration DISABLED_BasicConfiguration
+#else
+#define MAYBE_BasicConfiguration BasicConfiguration
+#endif
TEST_F(SyncManagerTestWithMockScheduler, BasicConfiguration) {
Sergey Ulanov 2012/07/30 23:31:40 update this to MAYBE_?
ConfigureReason reason = CONFIGURE_REASON_RECONFIGURATION;
ModelTypeSet types_to_download(BOOKMARKS, PREFERENCES);
@@ -2734,6 +2740,12 @@ TEST_F(SyncManagerTest, PurgePartiallySyncedTypes) {
// Test CleanipDisabledTypes properly purges all disabled types as specified
// by the previous and current enabled params. Enabled partial types should not
// be purged.
+// Fails on Windows: crbug.com/139726
+#if defined(OS_WIN)
+#define MAYBE_PurgeDisabledTypes DISABLED_PurgeDisabledTypes
+#else
+#define MAYBE_PurgeDisabledTypes PurgeDisabledTypes
+#endif
TEST_F(SyncManagerTest, PurgeDisabledTypes) {
Sergey Ulanov 2012/07/30 23:31:40 and here
ModelSafeRoutingInfo routing_info;
GetModelSafeRoutingInfo(&routing_info);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698