Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10836015: Convert more automation calls to the JSON interface. (Closed)

Created:
8 years, 4 months ago by craigdh
Modified:
8 years, 4 months ago
Reviewers:
jam, Nirnimesh
CC:
chromium-reviews, Nirnimesh, kkania, anantha, robertshield, dyu1, dennis_jeffrey
Visibility:
Public.

Description

Convert more automation calls to the JSON interface. OpenFindInPage IsFindInPageVisible ResetToDefaultTheme OpenNewBrowserWindow CloseBrowserWindow GetBrowserWindowCount BUG=132794 TEST=PyAuto CONTINUOUS suite Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149527

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Fix some failing tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -127 lines) Patch
M chrome/browser/automation/testing_automation_provider.h View 4 chunks +31 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 11 chunks +98 lines, -15 lines 0 comments Download
M chrome/common/automation_messages_internal.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/automation/browser_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/automation/browser_proxy.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/test/functional/content.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/functional/multiprofile.py View 1 2 6 chunks +6 lines, -7 lines 0 comments Download
M chrome/test/functional/themes.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 3 chunks +94 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
craigdh
Nirnimesh: everything John: OWNER on chrome/browser/automation/
8 years, 4 months ago (2012-07-30 22:45:01 UTC) #1
Nirnimesh
LGTM https://chromiumcodereview.appspot.com/10836015/diff/2001/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): https://chromiumcodereview.appspot.com/10836015/diff/2001/chrome/browser/automation/testing_automation_provider.cc#newcode1169 chrome/browser/automation/testing_automation_provider.cc:1169: if (!args->GetBoolean("show", &show)) { All pyauto usage has ...
8 years, 4 months ago (2012-07-31 00:29:29 UTC) #2
jam
lgtm
8 years, 4 months ago (2012-07-31 15:40:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10836015/7001
8 years, 4 months ago (2012-08-01 20:32:42 UTC) #4
commit-bot: I haz the power
Try job failure for 10836015-7001 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-01 20:47:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10836015/7001
8 years, 4 months ago (2012-08-01 21:49:18 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 23:08:57 UTC) #7 
Change committed as 149527

Powered by Google App Engine
This is Rietveld 408576698