chrome/browser/chromeos/gdata/gdata_operations.h - Issue 10836011: Revert 148990 - gdrive: Get JSON feeds parsing off the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/gdata/gdata_operations.h

Issue 10836011: Revert 148990 - gdrive: Get JSON feeds parsing off the UI thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_documents_service_browsertest.cc ('k') | chrome/browser/chromeos/gdata/gdata_operations.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/gdata/gdata_operations.h

===================================================================

--- chrome/browser/chromeos/gdata/gdata_operations.h (revision 148995)

+++ chrome/browser/chromeos/gdata/gdata_operations.h (working copy)

@@ -100,7 +100,7 @@

protected:

// Overridden from UrlFetchOperationBase.

virtual GURL GetURL() const OVERRIDE;

- virtual void ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

+ virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;

// Overridden from net::URLFetcherDelegate.

@@ -249,12 +249,11 @@

// Overridden from GetDataOperation.

virtual GURL GetURL() const OVERRIDE;

- virtual void ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

+ virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

// Must override GetDataOperation's ParseResponse because the response is XML

// not JSON.

- virtual void ParseResponse(GDataErrorCode fetch_error_code,

- const std::string& data) OVERRIDE;

+ virtual base::Value* ParseResponse(const std::string& data) OVERRIDE;

private:

std::string app_id_;

GURL document_url_;

@@ -329,7 +328,7 @@

protected:

// Overridden from UrlFetchOperationBase.

virtual GURL GetURL() const OVERRIDE;

- virtual void ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

+ virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

virtual void NotifySuccessToOperationRegistry() OVERRIDE;

virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;

@@ -361,7 +360,7 @@

protected:

// Overridden from UrlFetchOperationBase.

virtual GURL GetURL() const OVERRIDE;

- virtual void ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

+ virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

virtual void NotifyStartToOperationRegistry() OVERRIDE;

virtual void NotifySuccessToOperationRegistry() OVERRIDE;

virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;