Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 10836002: [Sync] Fix race condition with notification startup (Closed)

Created:
8 years, 4 months ago by akalin
Modified:
8 years, 4 months ago
Reviewers:
rlarocque
CC:
chromium-reviews
Visibility:
Public.

Description

[Sync] Fix race condition with notification startup This fixes a race condition which may cause notifications to not work on startup. This is a minimal change for ease of merging. Unit tests will be landed in a separate patch. BUG=139424 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M sync/notifier/chrome_invalidation_client.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
+rlarocque for review (and to test locally)
8 years, 4 months ago (2012-07-28 09:50:05 UTC) #1
rlarocque
On 2012/07/28 09:50:05, akalin wrote: > +rlarocque for review (and to test locally) LGTM, though ...
8 years, 4 months ago (2012-07-28 19:06:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10836002/1
8 years, 4 months ago (2012-07-28 20:51:43 UTC) #3
akalin
On 2012/07/28 19:06:49, rlarocque wrote: > On 2012/07/28 09:50:05, akalin wrote: > > +rlarocque for ...
8 years, 4 months ago (2012-07-28 20:52:18 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-28 23:06:30 UTC) #5
Change committed as 148907

Powered by Google App Engine
This is Rietveld 408576698